Changeset 163626 in webkit


Ignore:
Timestamp:
Feb 7, 2014 10:20:01 AM (10 years ago)
Author:
commit-queue@webkit.org
Message:

childShouldCreateRenderer should return false for the mspace element
​https://bugs.webkit.org/show_bug.cgi?id=128325

Patch by Frédéric Wang <​fred.wang@free.fr> on 2014-02-07
Reviewed by Chris Fleizach.

Source/WebCore:

The mspace element can not have children so this makes its
childShouldCreateRenderer always return false.

Test: mathml/presentation/mspace-children.html

  • mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::childShouldCreateRenderer):

LayoutTests:

Add tests to ensure that the mspace element does not have renderer
children.

  • mathml/presentation/mspace-children-expected.png: Added.
  • mathml/presentation/mspace-children-expected.txt: Added.
  • mathml/presentation/mspace-children.html: Added.
  • platform/mathml/presentation/mspace-children-expected.txt: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r163625 r163626  
     12014-02-07  Frédéric Wang  <fred.wang@free.fr>
     2
     3        childShouldCreateRenderer should return false for the mspace element
     4        https://bugs.webkit.org/show_bug.cgi?id=128325
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Add tests to ensure that the mspace element does not have renderer
     9        children.
     10
     11        * mathml/presentation/mspace-children-expected.png: Added.
     12        * mathml/presentation/mspace-children-expected.txt: Added.
     13        * mathml/presentation/mspace-children.html: Added.
     14        * platform/mathml/presentation/mspace-children-expected.txt: Added.
     15
    1162014-02-07  Javier Fernandez  <jfernandez@igalia.com>
    217

  • trunk/Source/WebCore/ChangeLog

    r163625 r163626  
     12014-02-07  Frédéric Wang  <fred.wang@free.fr>
     2
     3        childShouldCreateRenderer should return false for the mspace element
     4        https://bugs.webkit.org/show_bug.cgi?id=128325
     5
     6        Reviewed by Chris Fleizach.
     7
     8        The mspace element can not have children so this makes its
     9        childShouldCreateRenderer always return false.
     10
     11        Test: mathml/presentation/mspace-children.html
     12
     13        * mathml/MathMLTextElement.cpp:
     14        (WebCore::MathMLTextElement::childShouldCreateRenderer):
     15
    1162014-02-07  Javier Fernandez  <jfernandez@igalia.com>
    217

  • trunk/Source/WebCore/mathml/MathMLTextElement.cpp

    r163553 r163626  
    8787bool MathMLTextElement::childShouldCreateRenderer(const Node& child) const
    8888{
    89     return child.isTextNode();
     89    return !hasLocalName(mspaceTag) && child.isTextNode();
    9090}
    9191
Note: See TracChangeset for help on using the changeset viewer.