Changeset 163636 in webkit
- Timestamp:
- Feb 7, 2014 11:43:26 AM (10 years ago)
- Location:
- trunk/Source/WebKit2
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit2/ChangeLog
r163635 r163636 1 2014-02-07 Anders Carlsson <andersca@apple.com> 2 3 Copying a WebPreferences object should be done through a member function 4 https://bugs.webkit.org/show_bug.cgi?id=128385 5 6 Reviewed by Andreas Kling. 7 8 * UIProcess/API/C/WKPreferences.cpp: 9 (WKPreferencesCreateCopy): 10 * UIProcess/WebPreferences.cpp: 11 (WebKit::WebPreferences::copy): 12 * UIProcess/WebPreferences.h: 13 1 14 2014-02-07 Anders Carlsson <andersca@apple.com> 2 15 -
trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
r163335 r163636 56 56 WKPreferencesRef WKPreferencesCreateCopy(WKPreferencesRef preferencesRef) 57 57 { 58 RefPtr<WebPreferences> preferences = WebPreferences::create(*toImpl(preferencesRef));58 RefPtr<WebPreferences> preferences = toImpl(preferencesRef)->copy(); 59 59 return toAPI(preferences.release().leakRef()); 60 60 } -
trunk/Source/WebKit2/UIProcess/WebPreferences.cpp
r154967 r163636 57 57 { 58 58 ASSERT(m_pageGroups.isEmpty()); 59 } 60 61 PassRefPtr<WebPreferences> WebPreferences::copy() const 62 { 63 return adoptRef(new WebPreferences(*this)); 59 64 } 60 65 -
trunk/Source/WebKit2/UIProcess/WebPreferences.h
r160384 r163636 53 53 } 54 54 55 static PassRefPtr<WebPreferences> create(const WebPreferences& other) 56 { 57 return adoptRef(new WebPreferences(other)); 58 } 55 virtual ~WebPreferences(); 59 56 60 virtual ~WebPreferences();57 PassRefPtr<WebPreferences> copy() const; 61 58 62 59 void addPageGroup(WebPageGroup*);
Note: See TracChangeset
for help on using the changeset viewer.