Changeset 163636 in webkit


Ignore:
Timestamp:
Feb 7, 2014 11:43:26 AM (10 years ago)
Author:
andersca@apple.com
Message:

Copying a WebPreferences object should be done through a member function
https://bugs.webkit.org/show_bug.cgi?id=128385

Reviewed by Andreas Kling.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreateCopy):

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::copy):

  • UIProcess/WebPreferences.h:
Location:
trunk/Source/WebKit2
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r163635 r163636  
     12014-02-07  Anders Carlsson  <andersca@apple.com>
     2
     3        Copying a WebPreferences object should be done through a member function
     4        https://bugs.webkit.org/show_bug.cgi?id=128385
     5
     6        Reviewed by Andreas Kling.
     7
     8        * UIProcess/API/C/WKPreferences.cpp:
     9        (WKPreferencesCreateCopy):
     10        * UIProcess/WebPreferences.cpp:
     11        (WebKit::WebPreferences::copy):
     12        * UIProcess/WebPreferences.h:
     13
    1142014-02-07  Anders Carlsson  <andersca@apple.com>
    215
  • trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp

    r163335 r163636  
    5656WKPreferencesRef WKPreferencesCreateCopy(WKPreferencesRef preferencesRef)
    5757{
    58     RefPtr<WebPreferences> preferences = WebPreferences::create(*toImpl(preferencesRef));
     58    RefPtr<WebPreferences> preferences = toImpl(preferencesRef)->copy();
    5959    return toAPI(preferences.release().leakRef());
    6060}
  • trunk/Source/WebKit2/UIProcess/WebPreferences.cpp

    r154967 r163636  
    5757{
    5858    ASSERT(m_pageGroups.isEmpty());
     59}
     60
     61PassRefPtr<WebPreferences> WebPreferences::copy() const
     62{
     63    return adoptRef(new WebPreferences(*this));
    5964}
    6065
  • trunk/Source/WebKit2/UIProcess/WebPreferences.h

    r160384 r163636  
    5353    }
    5454
    55     static PassRefPtr<WebPreferences> create(const WebPreferences& other)
    56     {
    57         return adoptRef(new WebPreferences(other));
    58     }
     55    virtual ~WebPreferences();
    5956
    60     virtual ~WebPreferences();
     57    PassRefPtr<WebPreferences> copy() const;
    6158
    6259    void addPageGroup(WebPageGroup*);
Note: See TracChangeset for help on using the changeset viewer.