Changeset 16366 in webkit


Ignore:
Timestamp:
Sep 14, 2006 3:58:15 PM (18 years ago)
Author:
beidson
Message:

Reviewed by Maciej

Fixed a bad iFrame crash, resolving some of the layout test badness


  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading):
  • Added a RefPtr to protect the frame itself to prevent its destruction during this method
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r16365 r16366  
     12006-09-14  Brady Eidson  <beidson@apple.com>
     2
     3        Reviewed by Maciej
     4
     5        Fixed a bad iFrame crash, resolving some of the layout test badness
     6
     7        * page/Frame.cpp:
     8        (WebCore::Frame::endIfNotLoading):
     9        - Added a RefPtr to protect the frame itself to prevent its destruction during this method
     10
    1112006-09-14  Justin Garcia  <justin.garcia@apple.com>
    212
  • trunk/WebCore/page/Frame.cpp

    r16363 r16366  
    729729void Frame::endIfNotLoading()
    730730{
     731    // The frame's last ref may be remove and it be deleted by checkCompleted(),
     732    // so we'll add a protective refcount
     733    RefPtr<Frame> protector(this);
     734   
    731735    if (d->m_bLoadingMainResource)
    732736        return;
Note: See TracChangeset for help on using the changeset viewer.