Changeset 163748 in webkit

Timestamp:

Feb 9, 2014 2:31:33 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r162768.
​http://trac.webkit.org/changeset/162768
​https://bugs.webkit.org/show_bug.cgi?id=128495

Causes crashes on GTK WK2 in three fast/forms tests.
(Requested by zdobersek on #webkit).

• UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/gtk/WebPopupMenuProxyGtk.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-02-09  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r162768.
+        http://trac.webkit.org/changeset/162768
+        https://bugs.webkit.org/show_bug.cgi?id=128495
+
+        Causes crashes on GTK WK2 in three fast/forms tests.
+        (Requested by zdobersek on #webkit).
+
+        * UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
+        (WebKit::WebPopupMenuProxyGtk::showPopupMenu):
+
 2014-02-08  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp

@@ -106 +106 @@
     g_signal_handler_disconnect(m_popup->platformMenu(), unmapHandler);
 
-    ASSERT(m_client);
+    if (!m_client)
+        return;
+
     m_client->valueChangedForPopupMenu(this, m_activeItem);
 }