Changeset 163875 in webkit


Ignore:
Timestamp:
Feb 11, 2014 8:14:55 AM (10 years ago)
Author:
berto@igalia.com
Message:

O_CLOEXEC in shm_open does not work on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=128572

Reviewed by Darin Adler.

The O_CLOEXEC is not supported by shm_open() and is also not
necessary since FD_CLOEXEC is already set by default when the new
file descriptor is created.

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::create):

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r163866 r163875  
     12014-02-11  Alberto Garcia  <berto@igalia.com>
     2
     3        O_CLOEXEC in shm_open does not work on FreeBSD
     4        https://bugs.webkit.org/show_bug.cgi?id=128572
     5
     6        Reviewed by Darin Adler.
     7
     8        The O_CLOEXEC is not supported by shm_open() and is also not
     9        necessary since FD_CLOEXEC is already set by default when the new
     10        file descriptor is created.
     11
     12        * Platform/unix/SharedMemoryUnix.cpp:
     13        (WebKit::SharedMemory::create):
     14
    1152014-02-10  Commit Queue  <commit-queue@webkit.org>
    216
  • trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp

    r163292 r163875  
    108108
    109109        do {
    110             fileDescriptor = shm_open(tempName.data(), O_CREAT | O_CLOEXEC | O_RDWR, S_IRUSR | S_IWUSR);
     110            fileDescriptor = shm_open(tempName.data(), O_CREAT | O_RDWR, S_IRUSR | S_IWUSR);
    111111        } while (fileDescriptor == -1 && errno == EINTR);
    112112    }
Note: See TracChangeset for help on using the changeset viewer.