Changeset 164028 in webkit


Ignore:
Timestamp:
Feb 13, 2014 5:25:27 AM (10 years ago)
Author:
ryuan.choi@samsung.com
Message:

[EFL][WK1] Do not include libsoup header in the public headers
https://bugs.webkit.org/show_bug.cgi?id=128701

Reviewed by Gyuyoung Kim.

Although ewebkit used libsoup internally, it's not good for EFL developers
to use it.
Instead, we should provide some wrapper APIs like ewk_network_proxy_uri_set
for future changes.

  • ewk/ewk_network.cpp: Removed soup related header,APIs and comments.

(ewk_network_tls_ca_certificates_path_set):

  • ewk/ewk_network.h: Ditto.
  • ewk/ewk_view.cpp: Ditto.
  • ewk/ewk_view.h: Ditto.
Location:
trunk/Source/WebKit/efl
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/efl/ChangeLog

    r163958 r164028  
     12014-02-13  Ryuan Choi  <ryuan.choi@samsung.com>
     2
     3        [EFL][WK1] Do not include libsoup header in the public headers
     4        https://bugs.webkit.org/show_bug.cgi?id=128701
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        Although ewebkit used libsoup internally, it's not good for EFL developers
     9        to use it.
     10        Instead, we should provide some wrapper APIs like ewk_network_proxy_uri_set
     11        for future changes.
     12
     13        * ewk/ewk_network.cpp: Removed soup related header,APIs and comments.
     14        (ewk_network_tls_ca_certificates_path_set):
     15        * ewk/ewk_network.h: Ditto.
     16        * ewk/ewk_view.cpp: Ditto.
     17        * ewk/ewk_view.h: Ditto.
     18
    1192014-02-12  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
    220
  • trunk/Source/WebKit/efl/ewk/ewk_network.cpp

    r161890 r164028  
    7575    g_object_set(defaultSession, "ssl-ca-file", bundlePath, NULL);
    7676}
    77 
    78 SoupSession* ewk_network_default_soup_session_get()
    79 {
    80     return WebCore::SoupNetworkSession::defaultSession().soupSession();
    81 }
  • trunk/Source/WebKit/efl/ewk/ewk_network.h

    r148507 r164028  
    2727
    2828#include <Eina.h>
    29 #include <libsoup/soup.h>
    3029
    3130#ifdef __cplusplus
     
    3736 *
    3837 * @param proxy URI to set
    39  *
    40  * @note If the libsoup backend is being used, this function has effect on
    41  * the @b default SoupSession, returned by ewk_network_default_soup_session_get().
    42  * If a different SoupSession is used and passed to ewk_view_soup_session_set(),
    43  * this function will not have any effect on it.
    4438 */
    4539EAPI void             ewk_network_proxy_uri_set(const char *proxy);
     
    5145 *
    5246 * @return current proxy URI or @c NULL if it's not set
    53  *
    54  * @note If the libsoup backend is being used, this function has effect on
    55  * the @b default SoupSession, returned by ewk_network_default_soup_session_get().
    56  * If a different SoupSession is used and passed to ewk_view_soup_session_set(),
    57  * this function will not have any effect on it.
    5847 */
    5948EAPI const char      *ewk_network_proxy_uri_get(void);
     
    6554 *
    6655 * @sa ewk_network_tls_ca_certificates_path_set
    67  *
    68  * @note If the libsoup backend is being used, this function has effect on
    69  * the @b default SoupSession, returned by ewk_network_default_soup_session_get().
    70  * If a different SoupSession is used and passed to ewk_view_soup_session_set(),
    71  * this function will not have any effect on it.
    7256 */
    7357EAPI Eina_Bool        ewk_network_tls_certificate_check_get(void);
     
    8165 *
    8266 * @sa ewk_network_tls_ca_certificates_path_set
    83  *
    84  * @note If the libsoup backend is being used, this function has effect on
    85  * the @b default SoupSession, returned by ewk_network_default_soup_session_get().
    86  * If a different SoupSession is used and passed to ewk_view_soup_session_set(),
    87  * this function will not have any effect on it.
    8867 */
    8968EAPI void             ewk_network_tls_certificate_check_set(Eina_Bool enable);
     
    10281 *
    10382 * @sa ewk_network_tls_certificate_check_set
    104  *
    105  * @note If the libsoup backend is being used, this function has effect on
    106  * the @b default SoupSession, returned by ewk_network_default_soup_session_get().
    107  * If a different SoupSession is used and passed to ewk_view_soup_session_set(),
    108  * this function will not have any effect on it.
    10983 */
    11084EAPI const char      *ewk_network_tls_ca_certificates_path_get(void);
     
    12599 *
    126100 * @sa ewk_network_tls_certificate_check_set
    127  *
    128  * @note If the libsoup backend is being used, this function has effect on
    129  * the @b default SoupSession, returned by ewk_network_default_soup_session_get().
    130  * If a different SoupSession is used and passed to ewk_view_soup_session_set(),
    131  * this function will not have any effect on it.
    132101 */
    133102EAPI void             ewk_network_tls_ca_certificates_path_set(const char *path);
    134 
    135 /**
    136  * Returns the default @c SoupSession used by all views.
    137  *
    138  * @return The default @c SoupSession in use.
    139  */
    140 EAPI SoupSession     *ewk_network_default_soup_session_get(void);
    141103
    142104#ifdef __cplusplus
  • trunk/Source/WebKit/efl/ewk/ewk_view.cpp

    r163761 r164028  
    8888#include <eina_safety_checks.h>
    8989#include <inttypes.h>
    90 #include <libsoup/soup.h>
    9190#include <limits>
    9291#include <math.h>
     
    44874486}
    44884487
    4489 SoupSession* ewk_view_soup_session_get(const Evas_Object* ewkView)
    4490 {
    4491     EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, 0);
    4492     EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, 0);
    4493     return WebCore::NetworkStorageSession::defaultStorageSession().soupNetworkSession().soupSession();
    4494 }
    4495 
    4496 void ewk_view_soup_session_set(Evas_Object* ewkView, SoupSession* session)
    4497 {
    4498     EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData);
    4499     EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv);
    4500     if (!SOUP_IS_SESSION_ASYNC(session)) {
    4501         ERR("WebKit requires an SoupSessionAsync to work properly, but "
    4502             "a SoupSessionSync was provided.");
    4503         return;
    4504     }
    4505     WebCore::NetworkStorageSession::defaultStorageSession().setSoupNetworkSession(WebCore::SoupNetworkSession::createForSoupSession(session));
    4506 }
    4507 
    45084488Eina_Bool ewk_view_setting_enable_xss_auditor_get(const Evas_Object* ewkView)
    45094489{
  • trunk/Source/WebKit/efl/ewk/ewk_view.h

    r162581 r164028  
    124124#include <Evas.h>
    125125#include <cairo.h>
    126 #include <libsoup/soup.h>
    127126
    128127#ifdef __cplusplus
     
    23512350
    23522351/**
    2353  * Returns the SoupSession associated with this view.
    2354  *
    2355  * By default, all views share the same, default soup session also available
    2356  * by calling ewk_network_default_soup_session_get.
    2357  *
    2358  * @param o The view to query.
    2359  *
    2360  * @sa ewk_view_soup_session_set, ewk_network_default_soup_session_get
    2361  */
    2362 EAPI SoupSession* ewk_view_soup_session_get(const Evas_Object *o);
    2363 
    2364 /**
    2365  * Associates a new SoupSession with this view.
    2366  *
    2367  * Only sessions of type SoupSessionAsync are supported.
    2368  *
    2369  * @note Changing the SoupSession should not be needed in most cases. If
    2370  *       a different SoupSession is used, the cookie management and some
    2371  *       network functions in ewk will not have any effect on it.
    2372  *
    2373  * @param o The view to change.
    2374  * @param session The new SoupSession.
    2375  *
    2376  * @sa ewk_view_soup_session_get, ewk_network_default_soup_session_get
    2377  */
    2378 EAPI void ewk_view_soup_session_set(Evas_Object *o, SoupSession *session);
    2379 
    2380 /**
    23812352 * Returns whether XSSAuditor feature is enabled.
    23822353 *
Note: See TracChangeset for help on using the changeset viewer.