Changeset 164028 in webkit
- Timestamp:
- Feb 13, 2014 5:25:27 AM (10 years ago)
- Location:
- trunk/Source/WebKit/efl
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/efl/ChangeLog
r163958 r164028 1 2014-02-13 Ryuan Choi <ryuan.choi@samsung.com> 2 3 [EFL][WK1] Do not include libsoup header in the public headers 4 https://bugs.webkit.org/show_bug.cgi?id=128701 5 6 Reviewed by Gyuyoung Kim. 7 8 Although ewebkit used libsoup internally, it's not good for EFL developers 9 to use it. 10 Instead, we should provide some wrapper APIs like ewk_network_proxy_uri_set 11 for future changes. 12 13 * ewk/ewk_network.cpp: Removed soup related header,APIs and comments. 14 (ewk_network_tls_ca_certificates_path_set): 15 * ewk/ewk_network.h: Ditto. 16 * ewk/ewk_view.cpp: Ditto. 17 * ewk/ewk_view.h: Ditto. 18 1 19 2014-02-12 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> 2 20 -
trunk/Source/WebKit/efl/ewk/ewk_network.cpp
r161890 r164028 75 75 g_object_set(defaultSession, "ssl-ca-file", bundlePath, NULL); 76 76 } 77 78 SoupSession* ewk_network_default_soup_session_get()79 {80 return WebCore::SoupNetworkSession::defaultSession().soupSession();81 } -
trunk/Source/WebKit/efl/ewk/ewk_network.h
r148507 r164028 27 27 28 28 #include <Eina.h> 29 #include <libsoup/soup.h>30 29 31 30 #ifdef __cplusplus … … 37 36 * 38 37 * @param proxy URI to set 39 *40 * @note If the libsoup backend is being used, this function has effect on41 * the @b default SoupSession, returned by ewk_network_default_soup_session_get().42 * If a different SoupSession is used and passed to ewk_view_soup_session_set(),43 * this function will not have any effect on it.44 38 */ 45 39 EAPI void ewk_network_proxy_uri_set(const char *proxy); … … 51 45 * 52 46 * @return current proxy URI or @c NULL if it's not set 53 *54 * @note If the libsoup backend is being used, this function has effect on55 * the @b default SoupSession, returned by ewk_network_default_soup_session_get().56 * If a different SoupSession is used and passed to ewk_view_soup_session_set(),57 * this function will not have any effect on it.58 47 */ 59 48 EAPI const char *ewk_network_proxy_uri_get(void); … … 65 54 * 66 55 * @sa ewk_network_tls_ca_certificates_path_set 67 *68 * @note If the libsoup backend is being used, this function has effect on69 * the @b default SoupSession, returned by ewk_network_default_soup_session_get().70 * If a different SoupSession is used and passed to ewk_view_soup_session_set(),71 * this function will not have any effect on it.72 56 */ 73 57 EAPI Eina_Bool ewk_network_tls_certificate_check_get(void); … … 81 65 * 82 66 * @sa ewk_network_tls_ca_certificates_path_set 83 *84 * @note If the libsoup backend is being used, this function has effect on85 * the @b default SoupSession, returned by ewk_network_default_soup_session_get().86 * If a different SoupSession is used and passed to ewk_view_soup_session_set(),87 * this function will not have any effect on it.88 67 */ 89 68 EAPI void ewk_network_tls_certificate_check_set(Eina_Bool enable); … … 102 81 * 103 82 * @sa ewk_network_tls_certificate_check_set 104 *105 * @note If the libsoup backend is being used, this function has effect on106 * the @b default SoupSession, returned by ewk_network_default_soup_session_get().107 * If a different SoupSession is used and passed to ewk_view_soup_session_set(),108 * this function will not have any effect on it.109 83 */ 110 84 EAPI const char *ewk_network_tls_ca_certificates_path_get(void); … … 125 99 * 126 100 * @sa ewk_network_tls_certificate_check_set 127 *128 * @note If the libsoup backend is being used, this function has effect on129 * the @b default SoupSession, returned by ewk_network_default_soup_session_get().130 * If a different SoupSession is used and passed to ewk_view_soup_session_set(),131 * this function will not have any effect on it.132 101 */ 133 102 EAPI void ewk_network_tls_ca_certificates_path_set(const char *path); 134 135 /**136 * Returns the default @c SoupSession used by all views.137 *138 * @return The default @c SoupSession in use.139 */140 EAPI SoupSession *ewk_network_default_soup_session_get(void);141 103 142 104 #ifdef __cplusplus -
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
r163761 r164028 88 88 #include <eina_safety_checks.h> 89 89 #include <inttypes.h> 90 #include <libsoup/soup.h>91 90 #include <limits> 92 91 #include <math.h> … … 4487 4486 } 4488 4487 4489 SoupSession* ewk_view_soup_session_get(const Evas_Object* ewkView)4490 {4491 EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, 0);4492 EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, 0);4493 return WebCore::NetworkStorageSession::defaultStorageSession().soupNetworkSession().soupSession();4494 }4495 4496 void ewk_view_soup_session_set(Evas_Object* ewkView, SoupSession* session)4497 {4498 EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData);4499 EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv);4500 if (!SOUP_IS_SESSION_ASYNC(session)) {4501 ERR("WebKit requires an SoupSessionAsync to work properly, but "4502 "a SoupSessionSync was provided.");4503 return;4504 }4505 WebCore::NetworkStorageSession::defaultStorageSession().setSoupNetworkSession(WebCore::SoupNetworkSession::createForSoupSession(session));4506 }4507 4508 4488 Eina_Bool ewk_view_setting_enable_xss_auditor_get(const Evas_Object* ewkView) 4509 4489 { -
trunk/Source/WebKit/efl/ewk/ewk_view.h
r162581 r164028 124 124 #include <Evas.h> 125 125 #include <cairo.h> 126 #include <libsoup/soup.h>127 126 128 127 #ifdef __cplusplus … … 2351 2350 2352 2351 /** 2353 * Returns the SoupSession associated with this view.2354 *2355 * By default, all views share the same, default soup session also available2356 * by calling ewk_network_default_soup_session_get.2357 *2358 * @param o The view to query.2359 *2360 * @sa ewk_view_soup_session_set, ewk_network_default_soup_session_get2361 */2362 EAPI SoupSession* ewk_view_soup_session_get(const Evas_Object *o);2363 2364 /**2365 * Associates a new SoupSession with this view.2366 *2367 * Only sessions of type SoupSessionAsync are supported.2368 *2369 * @note Changing the SoupSession should not be needed in most cases. If2370 * a different SoupSession is used, the cookie management and some2371 * network functions in ewk will not have any effect on it.2372 *2373 * @param o The view to change.2374 * @param session The new SoupSession.2375 *2376 * @sa ewk_view_soup_session_get, ewk_network_default_soup_session_get2377 */2378 EAPI void ewk_view_soup_session_set(Evas_Object *o, SoupSession *session);2379 2380 /**2381 2352 * Returns whether XSSAuditor feature is enabled. 2382 2353 *
Note: See TracChangeset
for help on using the changeset viewer.