Changeset 164142 in webkit


Ignore:
Timestamp:
Feb 14, 2014 4:48:09 PM (10 years ago)
Author:
jer.noble@apple.com
Message:

Add support for specced event handlers to HTMLMediaElement
​https://bugs.webkit.org/show_bug.cgi?id=128292

Reviewed by Andreas Kling.

Source/WebCore:

Test: media/media-event-listeners.html

Add explicit event listener IDL attributes to HTMLMediaElement.

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:

LayoutTests:

  • media/media-event-listeners-expected.txt: Added.
  • media/media-event-listeners.html: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r164140 r164142  
     12014-02-14  Jer Noble  <jer.noble@apple.com>
     2
     3        Add support for specced event handlers to HTMLMediaElement
     4        https://bugs.webkit.org/show_bug.cgi?id=128292
     5
     6        Reviewed by Andreas Kling.
     7
     8        * media/media-event-listeners-expected.txt: Added.
     9        * media/media-event-listeners.html: Added.
     10
    1112014-02-14  Ryosuke Niwa  <rniwa@webkit.org>
    212

  • trunk/Source/WebCore/ChangeLog

    r164139 r164142  
     12014-02-14  Jer Noble  <jer.noble@apple.com>
     2
     3        Add support for specced event handlers to HTMLMediaElement
     4        https://bugs.webkit.org/show_bug.cgi?id=128292
     5
     6        Reviewed by Andreas Kling.
     7
     8        Test: media/media-event-listeners.html
     9
     10        Add explicit event listener IDL attributes to HTMLMediaElement.
     11
     12        * html/HTMLMediaElement.h:
     13        * html/HTMLMediaElement.idl:
     14
    1152014-02-14  Oliver Hunt  <oliver@apple.com>
    216

  • trunk/Source/WebCore/html/HTMLMediaElement.h

    r164131 r164142  
    253253    double percentLoaded() const;
    254254
     255    DEFINE_ATTRIBUTE_EVENT_LISTENER(emptied);
     256    DEFINE_ATTRIBUTE_EVENT_LISTENER(loadedmetadata);
     257    DEFINE_ATTRIBUTE_EVENT_LISTENER(loadeddata);
     258    DEFINE_ATTRIBUTE_EVENT_LISTENER(canplay);
     259    DEFINE_ATTRIBUTE_EVENT_LISTENER(canplaythrough);
     260    DEFINE_ATTRIBUTE_EVENT_LISTENER(playing);
     261    DEFINE_ATTRIBUTE_EVENT_LISTENER(ended);
     262    DEFINE_ATTRIBUTE_EVENT_LISTENER(waiting);
     263    DEFINE_ATTRIBUTE_EVENT_LISTENER(durationchange);
     264    DEFINE_ATTRIBUTE_EVENT_LISTENER(timeupdate);
     265    DEFINE_ATTRIBUTE_EVENT_LISTENER(play);
     266    DEFINE_ATTRIBUTE_EVENT_LISTENER(pause);
     267    DEFINE_ATTRIBUTE_EVENT_LISTENER(ratechange);
     268    DEFINE_ATTRIBUTE_EVENT_LISTENER(volumechange);
     269
    255270#if ENABLE(VIDEO_TRACK)
    256271    PassRefPtr<TextTrack> addTextTrack(const String& kind, const String& label, const String& language, ExceptionCode&);

  • trunk/Source/WebCore/html/HTMLMediaElement.idl

    r160733 r164142  
    8484    [Reflect=muted] attribute boolean defaultMuted;
    8585
     86    attribute EventListener onemptied;
     87    attribute EventListener onloadedmetadata;
     88    attribute EventListener onloadeddata;
     89    attribute EventListener oncanplay;
     90    attribute EventListener oncanplaythrough;
     91    attribute EventListener onplaying;
     92    attribute EventListener onended;
     93    attribute EventListener onwaiting;
     94    attribute EventListener ondurationchange;
     95    attribute EventListener ontimeupdate;
     96    attribute EventListener onplay;
     97    attribute EventListener onpause;
     98    attribute EventListener onratechange;
     99    attribute EventListener onvolumechange;
     100
    86101    // WebKit extensions
    87102    attribute boolean webkitPreservesPitch;
Note: See TracChangeset for help on using the changeset viewer.