Changeset 164186 in webkit


Ignore:
Timestamp:
Feb 15, 2014 7:07:14 PM (10 years ago)
Author:
rniwa@webkit.org
Message:

Remove unused arguments from moveTo(Range*)
https://bugs.webkit.org/show_bug.cgi?id=128878

Reviewed by Antti Koivisto.

Cleanup.

  • bindings/objc/DOMUIKitExtensions.mm:

(-[DOMRange move:inDirection:]):
(-[DOMRange extend:inDirection:]):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::moveTo):

  • editing/FrameSelection.h:
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r164185 r164186  
     12014-02-15  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Remove unused arguments from moveTo(Range*)
     4        https://bugs.webkit.org/show_bug.cgi?id=128878
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Cleanup.
     9
     10        * bindings/objc/DOMUIKitExtensions.mm:
     11        (-[DOMRange move:inDirection:]):
     12        (-[DOMRange extend:inDirection:]):
     13        * editing/FrameSelection.cpp:
     14        (WebCore::FrameSelection::moveTo):
     15        * editing/FrameSelection.h:
     16
    1172014-02-15  Filip Pizlo  <fpizlo@apple.com>
    218
  • trunk/Source/WebCore/bindings/objc/DOMUIKitExtensions.mm

    r163712 r164186  
    9595    Range *range = core(self);
    9696    FrameSelection frameSelection;
    97     frameSelection.moveTo(range, DOWNSTREAM);
     97    frameSelection.moveTo(range);
    9898   
    9999    TextGranularity granularity = CharacterGranularity;
     
    122122    Range *range = core(self);
    123123    FrameSelection frameSelection;
    124     frameSelection.moveTo(range, DOWNSTREAM);
     124    frameSelection.moveTo(range);
    125125   
    126126    for (UInt32 i = 0; i < amount; i++)
  • trunk/Source/WebCore/editing/FrameSelection.cpp

    r164156 r164186  
    153153}
    154154
    155 void FrameSelection::moveTo(const Range *r, EAffinity affinity, EUserTriggered userTriggered)
    156 {
    157     VisibleSelection selection = r ? VisibleSelection(r->startPosition(), r->endPosition(), affinity) : VisibleSelection(Position(), Position(), affinity);
    158     setSelection(selection, defaultSetSelectionOptions(userTriggered));
     155void FrameSelection::moveTo(const Range* range)
     156{
     157    VisibleSelection selection = range ? VisibleSelection(range->startPosition(), range->endPosition()) : VisibleSelection();
     158    setSelection(selection);
    159159}
    160160
  • trunk/Source/WebCore/editing/FrameSelection.h

    r164133 r164186  
    136136    Element* rootEditableElementOrDocumentElement() const;
    137137     
    138     void moveTo(const Range*, EAffinity, EUserTriggered = NotUserTriggered);
     138    void moveTo(const Range*);
    139139    void moveTo(const VisiblePosition&, EUserTriggered = NotUserTriggered, CursorAlignOnScroll = AlignCursorOnScrollIfNeeded);
    140140    void moveTo(const VisiblePosition&, const VisiblePosition&, EUserTriggered = NotUserTriggered);
Note: See TracChangeset for help on using the changeset viewer.