Changeset 164234 in webkit

Timestamp:

Feb 17, 2014 11:22:14 AM (10 years ago)

Author:

stavila@adobe.com

Message:

[CSS Regions] Make regions unsplittable
​https://bugs.webkit.org/show_bug.cgi?id=128811

Reviewed by David Hyatt.

Source/WebCore:

At the moment, nested regions are not properly fragmented across regions. For the moment,
the regions will become unsplittable elements to avoid slicing. At a later time a proper
fragmentation algorithm should be written, also taking into consideration pagination strut.

Test: fast/regions/unsplittable-nested-region.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::isUnsplittableForPagination):

LayoutTests:

Added test for checking that nested regions are unsplittable.

• fast/regions/unsplittable-nested-region-expected.html: Added.
• fast/regions/unsplittable-nested-region.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/regions/unsplittable-nested-region-expected.html (added)
• LayoutTests/fast/regions/unsplittable-nested-region.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBox.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-02-17  Radu Stavila  <stavila@adobe.com>
+
+        [CSS Regions] Make regions unsplittable
+        https://bugs.webkit.org/show_bug.cgi?id=128811
+
+        Reviewed by David Hyatt.
+
+        Added test for checking that nested regions are unsplittable.
+
+        * fast/regions/unsplittable-nested-region-expected.html: Added.
+        * fast/regions/unsplittable-nested-region.html: Added.
+
 2014-02-17  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-02-17  Radu Stavila  <stavila@adobe.com>
+
+        [CSS Regions] Make regions unsplittable
+        https://bugs.webkit.org/show_bug.cgi?id=128811
+
+        Reviewed by David Hyatt.
+
+        At the moment, nested regions are not properly fragmented across regions. For the moment, 
+        the regions will become unsplittable elements to avoid slicing. At a later time a proper
+        fragmentation algorithm should be written, also taking into consideration pagination strut.
+
+        Test: fast/regions/unsplittable-nested-region.html
+
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::isUnsplittableForPagination):
+
 2014-02-17  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/rendering/RenderBox.cpp

@@ -4413 +4413 @@
 bool RenderBox::isUnsplittableForPagination() const
 {
-    return isReplaced() || hasUnsplittableScrollingOverflow() || (parent() && isWritingModeRoot());
+    return isReplaced() || hasUnsplittableScrollingOverflow() || (parent() && isWritingModeRoot()) || isRenderNamedFlowFragmentContainer();
 }