Changeset 164423 in webkit

Timestamp:

Feb 20, 2014 2:24:14 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

AX: Children Nodes for Canvas objects are not equal to Render Objects.
​https://bugs.webkit.org/show_bug.cgi?id=123568

Patch by Artur Moryc <​a.moryc@samsung.com> on 2014-02-20
Reviewed by Chris Fleizach.

Source/WebCore:

There is a difference in children nodes taken into account for RenderObject
and for NodeObject types. There is a problem with text nodes that are
focusable for EFL/GTK and therefore are not filtered out in the test like it
happens for the MAC port. Text nodes are eliminated in the
AccessibilityRenderObject::computeAccessibilityIsIgnored() method. The same
approach has been applied to the NodeObject to eliminate text nodes.

Covered by existing tests.

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):

LayoutTests:

The canvas-accessibilitynodeobject.html test is not failing anymore.

• platform/efl-wk1/TestExpectations:
• platform/efl-wk2/TestExpectations:
• platform/gtk/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl-wk1/TestExpectations (modified) (1 diff)
• LayoutTests/platform/efl-wk2/TestExpectations (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityNodeObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-02-20  Artur Moryc  <a.moryc@samsung.com>
+
+        AX: Children Nodes for Canvas objects are not equal to Render Objects.
+        https://bugs.webkit.org/show_bug.cgi?id=123568
+
+        Reviewed by Chris Fleizach.
+
+        The canvas-accessibilitynodeobject.html test is not failing anymore.
+
+        * platform/efl-wk1/TestExpectations:
+        * platform/efl-wk2/TestExpectations:
+        * platform/gtk/TestExpectations:
+
 2014-02-20  Frédéric Wang  <fred.wang@free.fr>
 

trunk/LayoutTests/platform/efl-wk1/TestExpectations

@@ -107 +107 @@
 webkit.org/b/111991 accessibility/aria-text-role.html [ Failure ]
 webkit.org/b/111992 accessibility/aria-used-on-image-maps.html [ Failure ]
-webkit.org/b/111994 accessibility/canvas-accessibilitynodeobject.html [ Failure ]
 webkit.org/b/111996 accessibility/canvas-fallback-content-2.html [ Failure ]
 webkit.org/b/111999 accessibility/disabled-controls-not-focusable.html [ Failure ]

trunk/LayoutTests/platform/efl-wk2/TestExpectations

@@ -265 +265 @@
 webkit.org/b/111988 accessibility/aria-readonly.html [ Failure ]
 webkit.org/b/111991 accessibility/aria-text-role.html [ Failure ]
-webkit.org/b/111994 accessibility/canvas-accessibilitynodeobject.html [ Failure ]
 webkit.org/b/111996 accessibility/canvas-fallback-content-2.html [ Failure ]
 webkit.org/b/111999 accessibility/disabled-controls-not-focusable.html [ Failure ]

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -1250 +1250 @@
 webkit.org/b/91319 css2.1/20110323/vertical-align-boxes-001.htm [ ImageOnlyFailure ]
 
-webkit.org/b/92100 accessibility/canvas-accessibilitynodeobject.html [ Failure ]
-
 webkit.org/b/93976 fast/css-generated-content/quotes-lang.html [ ImageOnlyFailure ]
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-02-20  Artur Moryc  <a.moryc@samsung.com>
+
+        AX: Children Nodes for Canvas objects are not equal to Render Objects.
+        https://bugs.webkit.org/show_bug.cgi?id=123568
+
+        Reviewed by Chris Fleizach.
+
+        There is a difference in children nodes taken into account for RenderObject
+        and for NodeObject types. There is a problem with text nodes that are
+        focusable for EFL/GTK and therefore are not filtered out in the test like it
+        happens for the MAC port. Text nodes are eliminated in the
+        AccessibilityRenderObject::computeAccessibilityIsIgnored() method. The same
+        approach has been applied to the NodeObject to eliminate text nodes.
+
+        Covered by existing tests.
+
+        * accessibility/AccessibilityNodeObject.cpp:
+        (WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):
+
 2014-02-20  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp

@@ -429 +429 @@
             return true;
     }
-    
+
+    AccessibilityObjectInclusion decision = defaultObjectInclusion();
+    if (decision == IncludeObject)
+        return false;
+    if (decision == IgnoreObject)
+        return true;
     // If this element is within a parent that cannot have children, it should not be exposed.
     if (isDescendantOfBarrenParent())