Changeset 164941 in webkit


Ignore:
Timestamp:
Mar 2, 2014 7:36:53 AM (10 years ago)
Author:
thiago.lacerda@openbossa.org
Message:

Updating some WebRTC and MediaStream LayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=129442

Reviewed by Eric Carlson.

Due to changes in JavaScriptCore (in r163562), some LayoutTests in fast/mediastream needed to be updated:

  • MediaStreamTrack.html: checking hasOwnProperty in proto as well, until CustomGetter properties are moved to the prototype chain.
  • RTCIceCandidate.html and RTCSessionDescription.html: JSON.stringify are not considering properties in proto, so remove this for now.
  • fast/mediastream/MediaStreamTrack-expected.txt:
  • fast/mediastream/MediaStreamTrack.html:
  • fast/mediastream/RTCIceCandidate-expected.txt:
  • fast/mediastream/RTCIceCandidate.html:
  • fast/mediastream/RTCPeerConnection-have-local-answer.html: Removed. Other tests already test what this one was

testing

  • fast/mediastream/RTCSessionDescription-expected.txt:
  • fast/mediastream/RTCSessionDescription.html:
Location:
trunk/LayoutTests
Files:
1 deleted
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r164936 r164941  
     12014-03-02  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
     2
     3        Updating some WebRTC and MediaStream LayoutTests
     4        https://bugs.webkit.org/show_bug.cgi?id=129442
     5
     6        Reviewed by Eric Carlson.
     7
     8        Due to changes in JavaScriptCore (in r163562), some LayoutTests in fast/mediastream needed to be updated:
     9            - MediaStreamTrack.html: checking hasOwnProperty in __proto__ as well, until CustomGetter properties are
     10            moved to the prototype chain.
     11            - RTCIceCandidate.html and RTCSessionDescription.html: JSON.stringify are not considering properties in
     12            __proto__, so remove this for now.
     13
     14        * fast/mediastream/MediaStreamTrack-expected.txt:
     15        * fast/mediastream/MediaStreamTrack.html:
     16        * fast/mediastream/RTCIceCandidate-expected.txt:
     17        * fast/mediastream/RTCIceCandidate.html:
     18        * fast/mediastream/RTCPeerConnection-have-local-answer.html: Removed. Other tests already test what this one was
     19        testing
     20        * fast/mediastream/RTCSessionDescription-expected.txt:
     21        * fast/mediastream/RTCSessionDescription.html:
     22
    1232014-03-01  Commit Queue  <commit-queue@webkit.org>
    224

  • trunk/LayoutTests/fast/mediastream/MediaStreamTrack-expected.txt

    r158220 r164941  
    3838  states.volume = undefined
    3939  states.width = 1920
    40   states.sourceId = 239c24b0-2b15-11e3-8224-0800200c9a66
     40  states.aspectRatio = 1.78
    4141  states.height = 1080
    42   states.sourceType = camera
    4342  states.facingMode = user
    4443  states.frameRate = 30
    45   states.aspectRatio = 1.78
     44  states.sourceType = camera
     45  states.sourceId = 239c24b0-2b15-11e3-8224-0800200c9a66
    4646
    4747audioTrack = mediaStream.getAudioTracks()[0]
    … …  
    5959  states.volume = 50
    6060  states.width = undefined
    61   states.sourceId = 239c24b1-2b15-11e3-8224-0800200c9a66
     61  states.aspectRatio = undefined
    6262  states.height = undefined
    63   states.sourceType = microphone
    6463  states.facingMode = undefined
    6564  states.frameRate = undefined
    66   states.aspectRatio = undefined
     65  states.sourceType = microphone
     66  states.sourceId = 239c24b1-2b15-11e3-8224-0800200c9a66
    6767
    6868videoTrack2 = videoTrack.clone()
    … …  
    9898  states.volume = undefined
    9999  states.width = 1920
    100   states.sourceId = 239c24b0-2b15-11e3-8224-0800200c9a66
     100  states.aspectRatio = 1.78
    101101  states.height = 1080
    102   states.sourceType = camera
    103102  states.facingMode = user
    104103  states.frameRate = 30
    105   states.aspectRatio = 1.78
     104  states.sourceType = camera
     105  states.sourceId = 239c24b0-2b15-11e3-8224-0800200c9a66
    106106PASS videoTrack.id is not videoTrack2.id
    107107PASS videoTrack.kind is videoTrack2.kind

  • trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html

    r158220 r164941  
    109109                    shouldBeEqualToString('states.sourceType', 'microphone');
    110110                for (var property in states) {
    111                     if (states.hasOwnProperty(property))
     111                    // When https://webkit.org/b/129375 is fixed, we have to remove
     112                    // states.hasOwnProperty(property), because all the attributes
     113                    // will be in the prototype chain.
     114                    if (states.hasOwnProperty(property) || states.__proto__.hasOwnProperty(property))
    112115                        debug("  states." + property + " = " + limitPrecision(states[property], 2));
    113116                }

  • trunk/LayoutTests/fast/mediastream/RTCIceCandidate-expected.txt

    r159349 r164941  
    44
    55
    6 PASS candidate = new RTCIceCandidate(initializer); did not throw exception.
    7 PASS candidate.candidate is "foo"
    8 PASS candidate.sdpMid is "bar"
    9 PASS candidate.sdpMLineIndex is 6
    10 PASS initializer = JSON.parse(JSON.stringify(candidate)); did not throw exception.
    116PASS candidate = new RTCIceCandidate(initializer); did not throw exception.
    127PASS candidate.candidate is "foo"

  • trunk/LayoutTests/fast/mediastream/RTCIceCandidate.html

    r159349 r164941  
    1212            var initializer = {candidate:"foo", sdpMid:"bar", sdpMLineIndex:6};
    1313            var candidate;
    14             shouldNotThrow('candidate = new RTCIceCandidate(initializer);');
    15             shouldBe('candidate.candidate', '"foo"');
    16             shouldBe('candidate.sdpMid', '"bar"');
    17             shouldBe('candidate.sdpMLineIndex', '6');
    18 
    19             shouldNotThrow('initializer = JSON.parse(JSON.stringify(candidate));');
    20 
    2114            shouldNotThrow('candidate = new RTCIceCandidate(initializer);');
    2215            shouldBe('candidate.candidate', '"foo"');

  • trunk/LayoutTests/fast/mediastream/RTCSessionDescription-expected.txt

    r159938 r164941  
    55
    66PASS sessionDescription = new RTCSessionDescription(); did not throw exception.
    7 PASS sessionDescription = new RTCSessionDescription(initializer); did not throw exception.
    8 PASS sessionDescription.type is "offer"
    9 PASS sessionDescription.sdp is "foobar"
    10 PASS initializer = JSON.parse(JSON.stringify(sessionDescription)); did not throw exception.
    117PASS sessionDescription = new RTCSessionDescription(initializer); did not throw exception.
    128PASS sessionDescription.type is "offer"

  • trunk/LayoutTests/fast/mediastream/RTCSessionDescription.html

    r159230 r164941  
    1313            var sessionDescription;
    1414            shouldNotThrow("sessionDescription = new RTCSessionDescription();");
    15             shouldNotThrow("sessionDescription = new RTCSessionDescription(initializer);");
    16             shouldBe('sessionDescription.type', '"offer"');
    17             shouldBe('sessionDescription.sdp', '"foobar"');
    18 
    19             shouldNotThrow('initializer = JSON.parse(JSON.stringify(sessionDescription));');
    20 
    2115            shouldNotThrow("sessionDescription = new RTCSessionDescription(initializer);");
    2216            shouldBe('sessionDescription.type', '"offer"');
Note: See TracChangeset for help on using the changeset viewer.