Changeset 164980 in webkit

Timestamp:

Mar 3, 2014 2:16:55 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] webkit_dom_range_compare_boundary_points fails when 0 is passed as how parameter
​https://bugs.webkit.org/show_bug.cgi?id=129145

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-03-03
Reviewed by Carlos Garcia Campos.

While generating GObject DOM API the generator should skip non pointer
types while generating the g_return_val_if_fail macro.
This will avoid the situation when Range.START_TO_START is defined as 0,
thus the webkit_dom_range_compare_boundary_points function will fail
everytime it is called with 0 as how value.

• bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorGObject.pm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-03-03  Tomas Popela  <tpopela@redhat.com>
+
+        [GTK] webkit_dom_range_compare_boundary_points fails when 0 is passed as how parameter
+        https://bugs.webkit.org/show_bug.cgi?id=129145
+
+        Reviewed by Carlos Garcia Campos.
+
+        While generating GObject DOM API the generator should skip non pointer
+        types while generating the g_return_val_if_fail macro.
+        This will avoid the situation when Range.START_TO_START is defined as 0,
+        thus the webkit_dom_range_compare_boundary_points function will fail
+        everytime it is called with 0 as how value.
+
+        * bindings/scripts/CodeGeneratorGObject.pm:
+        (GenerateFunction):
+
 2014-03-03  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm

@@ -1054 +1054 @@
         my $paramName = $param->name;
         my $paramIDLType = $param->type;
-        my $paramTypeIsPrimitive = $codeGenerator->IsPrimitiveType($paramIDLType);
-        my $paramIsGDOMType = IsGDOMClassType($paramIDLType);
-        if (!$paramTypeIsPrimitive) {
+        my $paramTypeIsPointer = !$codeGenerator->IsNonPointerType($paramIDLType);
+        if ($paramTypeIsPointer) {
             $gReturnMacro = GetGReturnMacro($paramName, $paramIDLType, $returnType, $functionName);
             push(@cBody, $gReturnMacro);