Changeset 164981 in webkit

Timestamp:

Mar 3, 2014 2:17:55 AM (10 years ago)

Author:

lvidacs.u-szeged@partner.samsung.com

Message:

Move function calls outside loop in dom
​https://bugs.webkit.org/show_bug.cgi?id=126525

Reviewed by Csaba Osztrogonác.

Store the result of length() in a local variable and use it in each iteration.

• dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::isXMLMIMEType):

• dom/ElementData.cpp:

(WebCore::UniqueElementData::UniqueElementData):

• dom/EventContext.cpp:

(WebCore::TouchEventContext::checkReachability):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/DOMImplementation.cpp (modified) (1 diff)
• dom/ElementData.cpp (modified) (1 diff)
• dom/EventContext.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-03-03  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
+
+        Move function calls outside loop in dom
+        https://bugs.webkit.org/show_bug.cgi?id=126525
+
+        Reviewed by Csaba Osztrogonác.
+
+        Store the result of length() in a local variable and use it in each iteration.
+
+        * dom/DOMImplementation.cpp:
+        (WebCore::DOMImplementation::isXMLMIMEType):
+        * dom/ElementData.cpp:
+        (WebCore::UniqueElementData::UniqueElementData):
+        * dom/EventContext.cpp:
+        (WebCore::TouchEventContext::checkReachability):
+
 2014-03-03  Tomas Popela  <tpopela@redhat.com>
 

trunk/Source/WebCore/dom/DOMImplementation.cpp

@@ -270 +270 @@
 
     // Again, mimeType ends with '+xml', no need to check the validity of that substring.
-    for (size_t i = 0; i < mimeType.length() - 4; ++i) {
+    size_t mimeLength = mimeType.length();
+    for (size_t i = 0; i < mimeLength - 4; ++i) {
         if (!isValidXMLMIMETypeChar(mimeType[i]) && i != slashPosition)
             return false;

trunk/Source/WebCore/dom/ElementData.cpp

@@ -141 +141 @@
     m_inlineStyle = other.m_inlineStyle;
 
-    m_attributeVector.reserveCapacity(other.length());
-    for (unsigned i = 0; i < other.length(); ++i)
+    unsigned otherLength = other.length();
+    m_attributeVector.reserveCapacity(otherLength);
+    for (unsigned i = 0; i < otherLength; ++i)
         m_attributeVector.uncheckedAppend(other.m_attributeArray[i]);
 }

trunk/Source/WebCore/dom/EventContext.cpp

@@ -128 +128 @@
 void TouchEventContext::checkReachability(TouchList* touchList) const
 {
-    for (size_t i = 0; i < touchList->length(); ++i)
+    size_t length = touchList->length();
+    for (size_t i = 0; i < length; ++i)
         ASSERT(isReachable(touchList->item(i)->target()->toNode()));
 }