Changeset 165197 in webkit

Timestamp:

Mar 6, 2014 10:47:57 AM (10 years ago)

Author:

akling@apple.com

Message:

Drop unlinked function code on memory pressure.
<​https://webkit.org/b/129789>

Make VM::discardAllCode() also drop UnlinkedFunctionCodeBlocks that
are not currently being compiled.

4.5 MB progression on Membuster.

Reviewed by Geoffrey Garen.

• heap/Heap.cpp:

(JSC::Heap::deleteAllUnlinkedFunctionCode):

• heap/Heap.h:
• runtime/VM.cpp:

(JSC::VM::discardAllCode):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• heap/Heap.cpp (modified) (1 diff)
• heap/Heap.h (modified) (1 diff)
• runtime/VM.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-03-06  Andreas Kling  <akling@apple.com>
+
+        Drop unlinked function code on memory pressure.
+        <https://webkit.org/b/129789>
+
+        Make VM::discardAllCode() also drop UnlinkedFunctionCodeBlocks that
+        are not currently being compiled.
+
+        4.5 MB progression on Membuster.
+
+        Reviewed by Geoffrey Garen.
+
+        * heap/Heap.cpp:
+        (JSC::Heap::deleteAllUnlinkedFunctionCode):
+        * heap/Heap.h:
+        * runtime/VM.cpp:
+        (JSC::VM::discardAllCode):
+
 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/heap/Heap.cpp

@@ -803 +803 @@
 }
 
+void Heap::deleteAllUnlinkedFunctionCode()
+{
+    for (ExecutableBase* current = m_compiledCode.head(); current; current = current->next()) {
+        if (!current->isFunctionExecutable())
+            continue;
+        static_cast<FunctionExecutable*>(current)->clearUnlinkedCodeForRecompilationIfNotCompiling();
+    }
+}
+
 void Heap::deleteUnmarkedCompiledCode()
 {

trunk/Source/JavaScriptCore/heap/Heap.h

@@ -191 +191 @@
 
         JS_EXPORT_PRIVATE void deleteAllCompiledCode();
+        void deleteAllUnlinkedFunctionCode();
 
         void didAllocate(size_t);

trunk/Source/JavaScriptCore/runtime/VM.cpp

@@ -526 +526 @@
     m_codeCache->clear();
     heap.deleteAllCompiledCode();
+    heap.deleteAllUnlinkedFunctionCode();
     heap.reportAbandonedObjectGraph();
 }