Changeset 165481 in webkit


Ignore:
Timestamp:
Mar 12, 2014 11:00:17 AM (10 years ago)
Author:
akling@apple.com
Message:

BundlePageDiagnosticLoggingClient leaks every string passing through it.
<https://webkit.org/b/130140>
<rdar://problem/15416838>

Use toAPI() instead of toCopiedAPI() so the receiving end doesn't need
to worry about adopting the WKStringRef.

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:

(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r165479 r165481  
     12014-03-12  Andreas Kling  <akling@apple.com>
     2
     3        BundlePageDiagnosticLoggingClient leaks every string passing through it.
     4        <https://webkit.org/b/130140>
     5        <rdar://problem/15416838>
     6
     7        Use toAPI() instead of toCopiedAPI() so the receiving end doesn't need
     8        to worry about adopting the WKStringRef.
     9
     10        Reviewed by Anders Carlsson.
     11
     12        * WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:
     13        (WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
     14
    1152014-03-12  Tim Horton  <timothy_horton@apple.com>
    216
  • trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp

    r159988 r165481  
    3636    if (!m_client.logDiagnosticMessage)
    3737        return;
    38     m_client.logDiagnosticMessage(toAPI(page), toCopiedAPI(message), toCopiedAPI(description), toCopiedAPI(success), m_client.base.clientInfo);
     38    m_client.logDiagnosticMessage(toAPI(page), toAPI(message), toAPI(description), toAPI(success), m_client.base.clientInfo);
    3939}
    4040
Note: See TracChangeset for help on using the changeset viewer.