Changeset 165614 in webkit


Ignore:
Timestamp:
Mar 14, 2014 4:58:54 AM (10 years ago)
Author:
zandobersek@gmail.com
Message:

Unnecessary ImplementationLacksVTable IDL attribute used for RTCConfiguration, RTCIceServer
https://bugs.webkit.org/show_bug.cgi?id=130230

Reviewed by Philippe Normand.

The RTCConfiguration and RTCIceServer classes do not own virtual tables, so using the
ImplementationLacksVTable attribute in the IDL interface leads to a compile-time assertion
failure in the generates JSC wrappers because none of the classes is polymorphic.

  • Modules/mediastream/RTCConfiguration.idl:
  • Modules/mediastream/RTCIceServer.idl:
Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r165613 r165614  
     12014-03-14  Zan Dobersek  <zdobersek@igalia.com>
     2
     3        Unnecessary ImplementationLacksVTable IDL attribute used for RTCConfiguration, RTCIceServer
     4        https://bugs.webkit.org/show_bug.cgi?id=130230
     5
     6        Reviewed by Philippe Normand.
     7
     8        The RTCConfiguration and RTCIceServer classes do not own virtual tables, so using the
     9        ImplementationLacksVTable attribute in the IDL interface leads to a compile-time assertion
     10        failure in the generates JSC wrappers because none of the classes is polymorphic.
     11
     12        * Modules/mediastream/RTCConfiguration.idl:
     13        * Modules/mediastream/RTCIceServer.idl:
     14
    1152014-03-14  Javier Fernandez  <jfernandez@igalia.com>
    216
  • trunk/Source/WebCore/Modules/mediastream/RTCConfiguration.idl

    r165255 r165614  
    2929[
    3030    Conditional=MEDIA_STREAM,
    31     ImplementationLacksVTable,
    3231    NoInterfaceObject,
    3332] interface RTCConfiguration {
  • trunk/Source/WebCore/Modules/mediastream/RTCIceServer.idl

    r165255 r165614  
    2626[
    2727    Conditional=MEDIA_STREAM,
    28     ImplementationLacksVTable,
    2928    NoInterfaceObject,
    3029] interface RTCIceServer {
Note: See TracChangeset for help on using the changeset viewer.