Changeset 165716 in webkit

Timestamp:

Mar 16, 2014 8:41:28 PM (10 years ago)

Author:

gyuyoung.kim@samsung.com

Message:

AudioBufferSourceNode stop attribute shouldn't throw exception in finished state.
​https://bugs.webkit.org/show_bug.cgi?id=130000.

Patch by Praveen R Jadhav <​praveen.j@samsung.com> on 2014-03-16
Reviewed by Jer Noble.

AudioBufferSourceNode may go to FINISHED_STATE even before "stop" method is called
as silence rendered after audio data is played out when its not looping.
A call to "stop" method after this shouldn't throw exception.

• Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::stop):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webaudio/AudioScheduledSourceNode.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-03-16  Praveen R Jadhav  <praveen.j@samsung.com>
+
+        AudioBufferSourceNode stop attribute shouldn't throw exception in finished state.
+        https://bugs.webkit.org/show_bug.cgi?id=130000.
+
+        Reviewed by Jer Noble.
+
+        AudioBufferSourceNode may go to FINISHED_STATE even before "stop" method is called 
+        as silence rendered after audio data is played out when its not looping.
+        A call to "stop" method after this shouldn't throw exception.
+
+        * Modules/webaudio/AudioScheduledSourceNode.cpp:
+        (WebCore::AudioScheduledSourceNode::stop):
+
 2014-03-16  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp

@@ -157 +157 @@
 {
     ASSERT(isMainThread());
-    if (!(m_playbackState == SCHEDULED_STATE || m_playbackState == PLAYING_STATE) || (m_endTime != UnknownTime)) {
+    if ((m_playbackState == UNSCHEDULED_STATE) || (m_endTime != UnknownTime)) {
         ec = INVALID_STATE_ERR;
         return;