Changeset 165824 in webkit


Ignore:
Timestamp:
Mar 18, 2014 11:30:16 AM (10 years ago)
Author:
commit-queue@webkit.org
Message:

webkit-patch land shouldn't add a reviewer for unreviewed build fixes
https://bugs.webkit.org/show_bug.cgi?id=130220

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-03-18
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLog.set_reviewer):

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_set_reviewer):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r165818 r165824  
     12014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
     2
     3        webkit-patch land shouldn't add a reviewer for unreviewed build fixes
     4        https://bugs.webkit.org/show_bug.cgi?id=130220
     5
     6        Reviewed by Csaba Osztrogonác.
     7
     8        * Scripts/webkitpy/common/checkout/changelog.py:
     9        (ChangeLog.set_reviewer):
     10        * Scripts/webkitpy/common/checkout/changelog_unittest.py:
     11        (test_set_reviewer):
     12
    1132014-03-17  Filip Pizlo  <fpizlo@apple.com>
    214
  • trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py

    r165447 r165824  
    407407        reviewer_text = latest_entry.reviewer()
    408408        found_nobody = re.search("NOBODY\s*\(OOPS!\)", latest_entry_contents, re.MULTILINE)
    409 
    410         if not found_nobody and not reviewer_text:
     409        found_reviewer_or_unreviewed = latest_entry.has_valid_reviewer()
     410        if not found_nobody and not found_reviewer_or_unreviewed and not reviewer_text:
    411411            bug_url_number_of_items = len(re.findall(config_urls.bug_url_long, latest_entry_contents, re.MULTILINE))
    412412            bug_url_number_of_items += len(re.findall(config_urls.bug_url_short, latest_entry_contents, re.MULTILINE))
  • trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py

    r156895 r165824  
    557557'''
    558558
     559    _new_entry_boilerplate_with_unreviewed = '''2009-08-19  Eric Seidel  <eric@webkit.org>
     560
     561        Need a short description (OOPS!).
     562        https://bugs.webkit.org/show_bug.cgi?id=12345
     563
     564        Unreviewed.
     565
     566        * Scripts/bugzilla-tool:
     567'''
     568
    559569    _new_entry_boilerplate_with_multiple_bugurl = '''2009-08-19  Eric Seidel  <eric@webkit.org>
    560570
     
    595605        expected_contents = changelog_contents.replace('NOBODY (OOPS!)', reviewer_name)
    596606        self.assertEqual(actual_contents.splitlines(), expected_contents.splitlines())
     607
     608        changelog_contents = u"%s\n%s" % (self._new_entry_boilerplate_with_unreviewed, self._example_changelog)
     609        fs.write_text_file(self._changelog_path, changelog_contents)
     610        ChangeLog(self._changelog_path, fs).set_reviewer(reviewer_name)
     611        actual_contents = fs.read_text_file(self._changelog_path)
     612        self.assertEqual(actual_contents.splitlines(), changelog_contents.splitlines())
    597613
    598614        changelog_contents_without_reviewer_line = u"%s\n%s" % (self._new_entry_boilerplate_without_reviewer_line, self._example_changelog)
Note: See TracChangeset for help on using the changeset viewer.