Changeset 165841 in webkit

Timestamp:

Mar 18, 2014 1:45:27 PM (10 years ago)

Author:

andersca@apple.com

Message:

REGRESSION: Visited link coloring seems to be completely broken in tip of tree
​https://bugs.webkit.org/show_bug.cgi?id=130419
<rdar://problem/16337850>

Reviewed by Dan Bernstein.

Make sure to send any queued up messages before calling connectionWillOpen so we'll ensure
FIFO ordering if any messages are sent from within connectionWillOpen.

• Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::didFinishLaunching):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/ChildProcessProxy.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-03-18  Anders Carlsson  <andersca@apple.com>
+
+        REGRESSION: Visited link coloring seems to be completely broken in tip of tree
+        https://bugs.webkit.org/show_bug.cgi?id=130419
+        <rdar://problem/16337850>
+
+        Reviewed by Dan Bernstein.
+
+        Make sure to send any queued up messages before calling connectionWillOpen so we'll ensure
+        FIFO ordering if any messages are sent from within connectionWillOpen.
+
+        * Shared/ChildProcessProxy.cpp:
+        (WebKit::ChildProcessProxy::didFinishLaunching):
+
 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebKit2/Shared/ChildProcessProxy.cpp

@@ -133 +133 @@
 #endif
 
-    connectionWillOpen(m_connection.get());
-    m_connection->open();
-
     for (size_t i = 0; i < m_pendingMessages.size(); ++i) {
         std::unique_ptr<IPC::MessageEncoder> message = std::move(m_pendingMessages[i].first);
@@ -141 +138 @@
         m_connection->sendMessage(std::move(message), messageSendFlags);
     }
+
+    connectionWillOpen(m_connection.get());
+    m_connection->open();
 
     m_pendingMessages.clear();