Changeset 166166 in webkit


Ignore:
Timestamp:
Mar 24, 2014 8:24:02 AM (10 years ago)
Author:
rgabor@webkit.org
Message:

[ARM64] GNU assembler doesn't work with LLInt arm64 backend.
https://bugs.webkit.org/show_bug.cgi?id=130453

Reviewed by Filip Pizlo.

Change fp and lr to x29 and x30. Add both operand kinds to emitARM64()
at sxtw and uxtw instructions.

  • offlineasm/arm64.rb:
Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r166149 r166166  
     12014-03-24  Gabor Rapcsanyi  <rgabor@webkit.org>
     2
     3        [ARM64] GNU assembler doesn't work with LLInt arm64 backend.
     4        https://bugs.webkit.org/show_bug.cgi?id=130453
     5       
     6        Reviewed by Filip Pizlo.
     7
     8        Change fp and lr to x29 and x30. Add both operand kinds to emitARM64()
     9        at sxtw and uxtw instructions.
     10
     11        * offlineasm/arm64.rb:
     12
    1132014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
    214
  • trunk/Source/JavaScriptCore/offlineasm/arm64.rb

    r165205 r166166  
    130130            'sp'
    131131        when 'lr'
    132             'lr'
     132            'x30'
    133133        else
    134134            raise "Bad register name #{@name} at #{codeOriginString}"
     
    588588            }
    589589        when "popLRAndFP"
    590             $asm.puts "ldp fp, lr, [sp], #16"
     590            $asm.puts "ldp x29, x30, [sp], #16"
    591591        when "pushLRAndFP"
    592             $asm.puts "stp fp, lr, [sp, #-16]!"
     592            $asm.puts "stp x29, x30, [sp, #-16]!"
    593593        when "popCalleeSaves"
    594594            $asm.puts "ldp x28, x27, [sp], #16"
     
    610610            end
    611611        when "sxi2p"
    612             emitARM64("sxtw", operands, :ptr)
     612            emitARM64("sxtw", operands, [:int, :ptr])
    613613        when "sxi2q"
    614             emitARM64("sxtw", operands, :ptr)
     614            emitARM64("sxtw", operands, [:int, :ptr])
    615615        when "zxi2p"
    616             emitARM64("uxtw", operands, :ptr)
     616            emitARM64("uxtw", operands, [:int, :ptr])
    617617        when "zxi2q"
    618             emitARM64("uxtw", operands, :ptr)
     618            emitARM64("uxtw", operands, [:int, :ptr])
    619619        when "nop"
    620620            $asm.puts "nop"
Note: See TracChangeset for help on using the changeset viewer.