Changeset 166277 in webkit
- Timestamp:
- Mar 25, 2014 7:30:27 PM (10 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r166263 r166277 1 2014-03-25 Sanghyup Lee <sh53.lee@samsung.com> 2 3 When the mouse is upped after dragged out of shadowDOM, it should lose :active. 4 https://bugs.webkit.org/show_bug.cgi?id=130660 5 6 Reviewed by Darin Adler. 7 8 * fast/css/hover-active-drag-expected.txt: Added a test for textarea. 9 * fast/css/hover-active-drag.html: Updated. 10 1 11 2014-03-25 Filip Pizlo <fpizlo@apple.com> 2 12 -
trunk/LayoutTests/fast/css/hover-active-drag-expected.txt
r102632 r166277 1 1 2 Dragging out of an element should cause it to lose :hover 2 3 … … 13 14 PASS background is "rgb(0, 0, 0)" 14 15 PASS background is "rgb(0, 0, 0)" 16 PASS background is "rgb(255, 0, 0)" 17 PASS background is "rgb(255, 255, 0)" 18 PASS background is "rgb(0, 255, 0)" 19 PASS background is "rgb(0, 0, 0)" 15 20 16 21 -
trunk/LayoutTests/fast/css/hover-active-drag.html
r155263 r166277 1 1 <!DOCTYPE html> 2 2 <style> 3 div { background: rgb(0, 0, 0); }4 div:hover { background: rgb(255, 0, 0); }5 div:hover:active { background: rgb(255, 255, 0); }6 div:active { background: rgb(0, 255, 0); }7 div {3 div, textarea { background: rgb(0, 0, 0); } 4 div:hover, textarea:hover { background: rgb(255, 0, 0); } 5 div:hover:active, textarea:hover:active { background: rgb(255, 255, 0); } 6 div:active, textarea:active { background: rgb(0, 255, 0); } 7 div, textarea { 8 8 width: 100px; 9 9 height: 100px; … … 15 15 <div id="box"></div> 16 16 <div id="box2"></div> 17 <textarea id="textarea"></textarea> 17 18 <pre id="description"></div> 18 19 <pre id="console"></pre> … … 60 61 shouldHaveBackground(box, 'rgb(0, 0, 0)') 61 62 shouldHaveBackground(box2, 'rgb(0, 0, 0)') 63 64 // Move into the textarea. 65 eventSender.mouseMoveTo(50, 250) 66 shouldHaveBackground(textarea, 'rgb(255, 0, 0)') 67 68 eventSender.mouseDown() 69 shouldHaveBackground(textarea, 'rgb(255, 255, 0)') 70 71 eventSender.mouseMoveTo(400, 250) 72 shouldHaveBackground(textarea, 'rgb(0, 255, 0)') 73 74 eventSender.mouseUp() 75 shouldHaveBackground(textarea, 'rgb(0, 0, 0)') 62 76 } 63 77 </script> -
trunk/Source/WebCore/ChangeLog
r166274 r166277 1 2014-03-25 Sanghyup Lee <sh53.lee@samsung.com> 2 3 When the mouse is upped after dragged out of shadowDOM, it should lose :active. 4 https://bugs.webkit.org/show_bug.cgi?id=130660 5 6 Reviewed by Darin Adler. 7 8 This caused a regression after r165037. 9 When we have to clear :active style of shadow DOM, we should clear host's style. 10 This patch replaces parentElement() by parentOrShadowHostElement(). 11 12 * dom/Document.cpp: 13 (WebCore::Document::updateHoverActiveState): 14 1 15 2014-03-25 Eric Carlson <eric.carlson@apple.com> 2 16 -
trunk/Source/WebCore/dom/Document.cpp
r166144 r166277 5842 5842 if (oldActiveElement && !request.active()) { 5843 5843 // We are clearing the :active chain because the mouse has been released. 5844 for (Element* curr = oldActiveElement; curr; curr = curr->parent Element()) {5844 for (Element* curr = oldActiveElement; curr; curr = curr->parentOrShadowHostElement()) { 5845 5845 curr->setActive(false); 5846 5846 m_userActionElements.setInActiveChain(curr, false);
Note: See TracChangeset
for help on using the changeset viewer.