Changeset 166326 in webkit

Timestamp:

Mar 26, 2014 4:35:39 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

-[WKWebProcessPlugInNodeHandle HTMLInputElementIsUserEdited] and -HTMLTextAreaElementIsUserEdited do not return the correct values.

​https://bugs.webkit.org/show_bug.cgi?id=130804

Patch by Cody Krieger <​cjk@apple.com> on 2014-03-26
Reviewed by Dan Bernstein.

The existing implementations of these methods are mis-cased
("HTMLInputELementIsUserEdited" and "HTMLTextAreaELementIsUserEdited" —
note the "EL" in both cases). This results in us getting
auto-synthesized getters for the HTMLInputElementIsUserEdited and
HTMLTextAreaElementIsUserEdited properties, which will return NO
unconditionally.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

Fix the capitalization of -HTMLInputElementIsUserEdited and
-HTMLTextAreaElementIsUserEdited.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-03-26  Cody Krieger  <cjk@apple.com>
+
+        -[WKWebProcessPlugInNodeHandle HTMLInputElementIsUserEdited] and -HTMLTextAreaElementIsUserEdited do not return the correct values.
+
+        https://bugs.webkit.org/show_bug.cgi?id=130804
+
+        Reviewed by Dan Bernstein.
+
+        The existing implementations of these methods are mis-cased
+        ("HTMLInputELementIsUserEdited" and "HTMLTextAreaELementIsUserEdited" —
+        note the "EL" in both cases). This results in us getting
+        auto-synthesized getters for the HTMLInputElementIsUserEdited and
+        HTMLTextAreaElementIsUserEdited properties, which will return NO
+        unconditionally.
+
+        * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
+        Fix the capitalization of -HTMLInputElementIsUserEdited and
+        -HTMLTextAreaElementIsUserEdited.
+
 2014-03-26  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm

@@ -79 +79 @@
 }
 
-- (BOOL)HTMLInputELementIsUserEdited
+- (BOOL)HTMLInputElementIsUserEdited
 {
     return _nodeHandle->htmlInputElementLastChangeWasUserEdit();
 }
 
-- (BOOL)HTMLTextAreaELementIsUserEdited
+- (BOOL)HTMLTextAreaElementIsUserEdited
 {
     return _nodeHandle->htmlTextAreaElementLastChangeWasUserEdit();