Changeset 166657 in webkit


Ignore:
Timestamp:
Apr 2, 2014 12:34:17 PM (10 years ago)
Author:
timothy@apple.com
Message:

Remove Input domain from the Web Inspector protocol.

​https://bugs.webkit.org/show_bug.cgi?id=131073

Reviewed by Joseph Pecoraro.

Source/WebCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorInputAgent.cpp: Removed.
  • inspector/InspectorInputAgent.h: Removed.
  • inspector/protocol/Input.json: Removed.

Source/WebInspectorUI:

  • UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js: Updated.
  • Versions/Inspector-iOS-7.0.json: Removed Input domain.

LayoutTests:

  • inspector-protocol/input/dispatchKeyEvent-expected.txt: Removed.
  • inspector-protocol/input/dispatchKeyEvent.html: Removed.
  • inspector-protocol/input/dispatchMouseEvent-expected.txt: Removed.
  • inspector-protocol/input/dispatchMouseEvent.html: Removed.
Location:
trunk
Files:
4 deleted
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r166650 r166657  
     12014-04-02  Timothy Hatcher  <timothy@apple.com>
     2
     3        Remove Input domain from the Web Inspector protocol.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=131073
     6
     7        Reviewed by Joseph Pecoraro.
     8
     9        * inspector-protocol/input/dispatchKeyEvent-expected.txt: Removed.
     10        * inspector-protocol/input/dispatchKeyEvent.html: Removed.
     11        * inspector-protocol/input/dispatchMouseEvent-expected.txt: Removed.
     12        * inspector-protocol/input/dispatchMouseEvent.html: Removed.
     13
    1142014-04-02  David Kilzer  <ddkilzer@apple.com>
    215

  • trunk/Source/WebCore/CMakeLists.txt

    r166648 r166657  
    763763    ${WEBCORE_DIR}/inspector/protocol/DOMStorage.json
    764764    ${WEBCORE_DIR}/inspector/protocol/IndexedDB.json
    765     ${WEBCORE_DIR}/inspector/protocol/Input.json
    766765    ${WEBCORE_DIR}/inspector/protocol/LayerTree.json
    767766    ${WEBCORE_DIR}/inspector/protocol/Network.json
    … …  
    15781577    inspector/InspectorHistory.cpp
    15791578    inspector/InspectorIndexedDBAgent.cpp
    1580     inspector/InspectorInputAgent.cpp
    15811579    inspector/InspectorInstrumentation.cpp
    15821580    inspector/InspectorInstrumentationCookie.cpp

  • trunk/Source/WebCore/ChangeLog

    r166654 r166657  
     12014-04-02  Timothy Hatcher  <timothy@apple.com>
     2
     3        Remove Input domain from the Web Inspector protocol.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=131073
     6
     7        Reviewed by Joseph Pecoraro.
     8
     9        * CMakeLists.txt:
     10        * DerivedSources.make:
     11        * WebCore.vcxproj/WebCore.vcxproj:
     12        * WebCore.vcxproj/WebCore.vcxproj.filters:
     13        * WebCore.xcodeproj/project.pbxproj:
     14        * inspector/InspectorAllInOne.cpp:
     15        * inspector/InspectorController.cpp:
     16        (WebCore::InspectorController::InspectorController):
     17        * inspector/InspectorInputAgent.cpp: Removed.
     18        * inspector/InspectorInputAgent.h: Removed.
     19        * inspector/protocol/Input.json: Removed.
     20
    1212014-04-02  Antti Koivisto  <antti@apple.com>
    222

  • trunk/Source/WebCore/DerivedSources.make

    r166622 r166657  
    11211121    $(WebCore)/inspector/protocol/DOMDebugger.json \
    11221122    $(WebCore)/inspector/protocol/DOMStorage.json \
    1123     $(WebCore)/inspector/protocol/Input.json \
    11241123    $(WebCore)/inspector/protocol/LayerTree.json \
    11251124    $(WebCore)/inspector/protocol/Network.json \

  • trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj

    r166642 r166657  
    1781217812    </ClCompile>
    1781317813    <ClCompile Include="..\inspector\InspectorIndexedDBAgent.cpp">
    17814       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</ExcludedFromBuild>
    17815       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|x64'">true</ExcludedFromBuild>
    17816       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release_WinCairo|Win32'">true</ExcludedFromBuild>
    17817       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release_WinCairo|x64'">true</ExcludedFromBuild>
    17818       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|Win32'">true</ExcludedFromBuild>
    17819       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|x64'">true</ExcludedFromBuild>
    17820     </ClCompile>
    17821     <ClCompile Include="..\inspector\InspectorInputAgent.cpp">
    1782217814      <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</ExcludedFromBuild>
    1782317815      <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|x64'">true</ExcludedFromBuild>
    … …  
    2107421066    <ClInclude Include="..\inspector\InspectorHistory.h" />
    2107521067    <ClInclude Include="..\inspector\InspectorIndexedDBAgent.h" />
    21076     <ClInclude Include="..\inspector\InspectorInputAgent.h" />
    2107721068    <ClInclude Include="..\inspector\InspectorInstrumentation.h" />
    2107821069    <ClInclude Include="..\inspector\InspectorInstrumentationCookie.h" />

  • trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters

    r166642 r166657  
    47834783      <Filter>inspector</Filter>
    47844784    </ClCompile>
    4785     <ClCompile Include="..\inspector\InspectorInputAgent.cpp">
    4786       <Filter>inspector</Filter>
    4787     </ClCompile>
    47884785    <ClCompile Include="..\inspector\InspectorInstrumentation.cpp">
    47894786      <Filter>inspector</Filter>
    … …  
    1239912396    </ClInclude>
    1240012397    <ClInclude Include="..\inspector\InspectorIndexedDBAgent.h">
    12401       <Filter>inspector</Filter>
    12402     </ClInclude>
    12403     <ClInclude Include="..\inspector\InspectorInputAgent.h">
    1240412398      <Filter>inspector</Filter>
    1240512399    </ClInclude>

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r166654 r166657  
    17141714                4B8AF4AA0B1CE02B00687690 /* ClipboardAccessPolicy.h in Headers */ = {isa = PBXBuildFile; fileRef = 4B8AF4A90B1CE02B00687690 /* ClipboardAccessPolicy.h */; settings = {ATTRIBUTES = (Private, ); }; };
    17151715                4BAE95B10B2FA9CE00AED8A0 /* EditorDeleteAction.h in Headers */ = {isa = PBXBuildFile; fileRef = 4BAE95B00B2FA9CE00AED8A0 /* EditorDeleteAction.h */; settings = {ATTRIBUTES = (Private, ); }; };
    1716                 4D273CF91669420800259CA1 /* InspectorInputAgent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4D273CF71669420800259CA1 /* InspectorInputAgent.cpp */; };
    1717                 4D273CFA1669420800259CA1 /* InspectorInputAgent.h in Headers */ = {isa = PBXBuildFile; fileRef = 4D273CF81669420800259CA1 /* InspectorInputAgent.h */; };
    17181716                4E1959210A39DABA00220FE5 /* MediaFeatureNames.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4E19591F0A39DABA00220FE5 /* MediaFeatureNames.cpp */; };
    17191717                4E1959220A39DABA00220FE5 /* MediaFeatureNames.h in Headers */ = {isa = PBXBuildFile; fileRef = 4E1959200A39DABA00220FE5 /* MediaFeatureNames.h */; };
    … …  
    86878685                4B8AF4A90B1CE02B00687690 /* ClipboardAccessPolicy.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = ClipboardAccessPolicy.h; sourceTree = "<group>"; };
    86888686                4BAE95B00B2FA9CE00AED8A0 /* EditorDeleteAction.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EditorDeleteAction.h; sourceTree = "<group>"; };
    8689                 4D273CF71669420800259CA1 /* InspectorInputAgent.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorInputAgent.cpp; sourceTree = "<group>"; };
    8690                 4D273CF81669420800259CA1 /* InspectorInputAgent.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorInputAgent.h; sourceTree = "<group>"; };
    86918687                4E19591F0A39DABA00220FE5 /* MediaFeatureNames.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = MediaFeatureNames.cpp; sourceTree = "<group>"; };
    86928688                4E1959200A39DABA00220FE5 /* MediaFeatureNames.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = MediaFeatureNames.h; sourceTree = "<group>"; };
    … …  
    1499514991                                7ACD88D114C08BD60084EDD2 /* InspectorIndexedDBAgent.cpp */,
    1499614992                                7ACD88D214C08BD60084EDD2 /* InspectorIndexedDBAgent.h */,
    14997                                 4D273CF71669420800259CA1 /* InspectorInputAgent.cpp */,
    14998                                 4D273CF81669420800259CA1 /* InspectorInputAgent.h */,
    1499914993                                20D629241253690B00081543 /* InspectorInstrumentation.cpp */,
    1500014994                                20D629251253690B00081543 /* InspectorInstrumentation.h */,
    … …  
    2420824202                                7A54858014E02D51006AE05A /* InspectorHistory.h in Headers */,
    2420924203                                7ACD88D414C08BD60084EDD2 /* InspectorIndexedDBAgent.h in Headers */,
    24210                                 4D273CFA1669420800259CA1 /* InspectorInputAgent.h in Headers */,
    2421124204                                20D629271253690B00081543 /* InspectorInstrumentation.h in Headers */,
    2421224205                                A5840E1D187B74D500843B10 /* InspectorInstrumentationCookie.h in Headers */,
    … …  
    2759627589                                7A54857F14E02D51006AE05A /* InspectorHistory.cpp in Sources */,
    2759727590                                7ACD88D314C08BD60084EDD2 /* InspectorIndexedDBAgent.cpp in Sources */,
    27598                                 4D273CF91669420800259CA1 /* InspectorInputAgent.cpp in Sources */,
    2759927591                                20D629261253690B00081543 /* InspectorInstrumentation.cpp in Sources */,
    2760027592                                A5840E1C187B74D500843B10 /* InspectorInstrumentationCookie.cpp in Sources */,

  • trunk/Source/WebCore/inspector/InspectorAllInOne.cpp

    r166622 r166657  
    4343#include "InspectorHistory.cpp"
    4444#include "InspectorIndexedDBAgent.cpp"
    45 #include "InspectorInputAgent.cpp"
    4645#include "InspectorInstrumentation.cpp"
    4746#include "InspectorInstrumentationCookie.cpp"

  • trunk/Source/WebCore/inspector/InspectorController.cpp

    r166622 r166657  
    4747#include "InspectorFrontendClient.h"
    4848#include "InspectorIndexedDBAgent.h"
    49 #include "InspectorInputAgent.h"
    5049#include "InspectorInstrumentation.h"
    5150#include "InspectorLayerTreeAgent.h"
    … …  
    160159    m_agents.append(std::make_unique<InspectorWorkerAgent>(m_instrumentingAgents.get()));
    161160
    162     m_agents.append(std::make_unique<InspectorInputAgent>(m_instrumentingAgents.get(), &page));
    163 
    164161    m_agents.append(std::make_unique<InspectorLayerTreeAgent>(m_instrumentingAgents.get()));
    165162

  • trunk/Source/WebInspectorUI/ChangeLog

    r166622 r166657  
     12014-04-02  Timothy Hatcher  <timothy@apple.com>
     2
     3        Remove Input domain from the Web Inspector protocol.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=131073
     6
     7        Reviewed by Joseph Pecoraro.
     8
     9        * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js: Updated.
     10        * Versions/Inspector-iOS-7.0.json: Removed Input domain.
     11
    1122014-04-01  Timothy Hatcher  <timothy@apple.com>
    213

  • trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js

    r166622 r166657  
    197197InspectorBackend.registerCommand("DOM.markUndoableState", [], []);
    198198InspectorBackend.registerCommand("DOM.focus", [{"name": "nodeId", "type": "number", "optional": false}], []);
    199 InspectorBackend.registerCommand("DOM.setFileInputFiles", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "files", "type": "object", "optional": false}], []);
    200199
    201200// CSS.
    … …  
    309308InspectorBackend.registerCommand("Worker.setAutoconnectToWorkers", [{"name": "value", "type": "boolean", "optional": false}], []);
    310309
    311 // Input.
    312 InspectorBackend.registerInputDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Input");
    313 InspectorBackend.registerCommand("Input.dispatchKeyEvent", [{"name": "type", "type": "string", "optional": false}, {"name": "modifiers", "type": "number", "optional": true}, {"name": "timestamp", "type": "number", "optional": true}, {"name": "text", "type": "string", "optional": true}, {"name": "unmodifiedText", "type": "string", "optional": true}, {"name": "keyIdentifier", "type": "string", "optional": true}, {"name": "windowsVirtualKeyCode", "type": "number", "optional": true}, {"name": "nativeVirtualKeyCode", "type": "number", "optional": true}, {"name": "macCharCode", "type": "number", "optional": true}, {"name": "autoRepeat", "type": "boolean", "optional": true}, {"name": "isKeypad", "type": "boolean", "optional": true}, {"name": "isSystemKey", "type": "boolean", "optional": true}], []);
    314 InspectorBackend.registerCommand("Input.dispatchMouseEvent", [{"name": "type", "type": "string", "optional": false}, {"name": "x", "type": "number", "optional": false}, {"name": "y", "type": "number", "optional": false}, {"name": "modifiers", "type": "number", "optional": true}, {"name": "timestamp", "type": "number", "optional": true}, {"name": "button", "type": "string", "optional": true}, {"name": "clickCount", "type": "number", "optional": true}], []);
    315 
    316310// LayerTree.
    317311InspectorBackend.registerLayerTreeDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "LayerTree");

  • trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json

    r166622 r166657  
    16881688                ],
    16891689                "description": "Focuses the given element."
    1690             },
    1691             {
    1692                 "name": "setFileInputFiles",
    1693                 "parameters": [
    1694                     { "name": "nodeId", "$ref": "NodeId", "description": "Id of the file input node to set files for." },
    1695                     { "name": "files", "type": "array", "items": { "type": "string" }, "description": "Array of file paths to set." }
    1696                 ],
    1697                 "description": "Sets files for the given file input element."
    16981690            }
    16991691        ],
    … …  
    28192811            }
    28202812        ]
    2821     },
    2822     {
    2823         "domain": "Input",
    2824         "types": [],
    2825         "commands": [
    2826             {
    2827                 "name": "dispatchKeyEvent",
    2828                 "parameters": [
    2829                     { "name": "type", "type": "string", "enum": ["keyDown", "keyUp", "rawKeyDown", "char"], "description": "Type of the key event." },
    2830                     { "name": "modifiers", "type": "integer", "optional": true, "description": "Bit field representing pressed modifier keys. Alt=1, Ctrl=2, Meta/Command=4, Shift=8 (default: 0)." },
    2831                     { "name": "timestamp", "type": "number", "optional": true, "description": "Time at which the event occurred. Measured in UTC time in seconds since January 1, 1970 (default: current time)." },
    2832                     { "name": "text", "type": "string", "optional": true, "description": "Text as generated by processing a virtual key code with a keyboard layout. Not needed for for <code>keyUp</code> and <code>rawKeyDown</code> events (default: \"\")" },
    2833                     { "name": "unmodifiedText", "type": "string", "optional": true, "description": "Text that would have been generated by the keyboard if no modifiers were pressed (except for shift). Useful for shortcut (accelerator) key handling (default: \"\")." },
    2834                     { "name": "keyIdentifier", "type": "string", "optional": true, "description": "Unique key identifier (e.g., 'U+0041') (default: \"\")." },
    2835                     { "name": "windowsVirtualKeyCode", "type": "integer", "optional": true, "description": "Windows virtual key code (default: 0)." },
    2836                     { "name": "nativeVirtualKeyCode", "type": "integer", "optional": true, "description": "Native virtual key code (default: 0)." },
    2837                     { "name": "macCharCode", "type": "integer", "optional": true, "description": "Mac character code (default: 0)." },
    2838                     { "name": "autoRepeat", "type": "boolean", "optional": true, "description": "Whether the event was generated from auto repeat (default: false)." },
    2839                     { "name": "isKeypad", "type": "boolean", "optional": true, "description": "Whether the event was generated from the keypad (default: false)." },
    2840                     { "name": "isSystemKey", "type": "boolean", "optional": true, "description": "Whether the event was a system key event (default: false)." }
    2841                 ],
    2842                 "description": "Dispatches a key event to the page."
    2843             },
    2844             {
    2845                 "name": "dispatchMouseEvent",
    2846                 "parameters": [
    2847                     { "name": "type", "type": "string", "enum": ["mousePressed", "mouseReleased", "mouseMoved"], "description": "Type of the mouse event." },
    2848                     { "name": "x", "type": "integer", "description": "X coordinate of the event relative to the main frame's viewport."},
    2849                     { "name": "y", "type": "integer", "description": "Y coordinate of the event relative to the main frame's viewport. 0 refers to the top of the viewport and Y increases as it proceeds towards the bottom of the viewport."},
    2850                     { "name": "modifiers", "type": "integer", "optional": true, "description": "Bit field representing pressed modifier keys. Alt=1, Ctrl=2, Meta/Command=4, Shift=8 (default: 0)." },
    2851                     { "name": "timestamp", "type": "number", "optional": true, "description": "Time at which the event occurred. Measured in UTC time in seconds since January 1, 1970 (default: current time)." },
    2852                     { "name": "button", "type": "string", "enum": ["none", "left", "middle", "right"], "optional": true, "description": "Mouse button (default: \"none\")." },
    2853                     { "name": "clickCount", "type": "integer", "optional": true, "description": "Number of times the mouse button was clicked (default: 0)." }
    2854                 ],
    2855                 "description": "Dispatches a mouse event to the page."
    2856             }
    2857         ],
    2858         "events": []
    28592813    },
    28602814    {
Note: See TracChangeset for help on using the changeset viewer.