Changeset 166675 in webkit

Timestamp:

Apr 2, 2014 4:29:12 PM (10 years ago)

Author:

timothy_horton@apple.com

Message:

RemoteLayerBackingStore doesn't need to clear opaque layers
​https://bugs.webkit.org/show_bug.cgi?id=131134

Reviewed by Simon Fraser.

• Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::display):
We don't need to clear opaque layers, because we'll paint
over the whole area. In addition, we should fill opaque layers
with a bright color in debug builds to make it very clear
that we've made a mistake (similar to what FrameView does).

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/mac/RemoteLayerBackingStore.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-04-02  Tim Horton  <timothy_horton@apple.com>
+
+        RemoteLayerBackingStore doesn't need to clear opaque layers
+        https://bugs.webkit.org/show_bug.cgi?id=131134
+
+        Reviewed by Simon Fraser.
+
+        * Shared/mac/RemoteLayerBackingStore.mm:
+        (WebKit::RemoteLayerBackingStore::display):
+        We don't need to clear opaque layers, because we'll paint
+        over the whole area. In addition, we should fill opaque layers
+        with a bright color in debug builds to make it very clear
+        that we've made a mistake (similar to what FrameView does).
+
 2014-04-02  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm

@@ -180 +180 @@
     scaledSize.scale(m_scale);
     IntSize expandedScaledSize = expandedIntSize(scaledSize);
+    IntRect expandedScaledLayerBounds(IntPoint(), expandedScaledSize);
 
     bool willPaintEntireBackingStore = m_dirtyRegion.contains(layerBounds);
@@ -196 +197 @@
 
         GraphicsContext& context = m_frontSurface->ensureGraphicsContext();
-        context.clearRect(FloatRect(FloatPoint(), expandedScaledSize));
+
+        if (!m_isOpaque)
+            context.clearRect(expandedScaledLayerBounds);
+
+#ifndef NDEBUG
+        if (m_isOpaque)
+            context.fillRect(expandedScaledLayerBounds, Color(255, 0, 0), ColorSpaceDeviceRGB);
+#endif
+
         context.scale(FloatSize(1, -1));
         context.translate(0, -expandedScaledSize.height());