Changeset 166723 in webkit
- Timestamp:
- Apr 3, 2014 9:36:18 AM (10 years ago)
- Location:
- trunk/Websites/perf.webkit.org
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Websites/perf.webkit.org/ChangeLog
r166701 r166723 1 2014-04-03 Ryosuke Niwa <rniwa@webkit.org> 2 3 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button 4 https://bugs.webkit.org/show_bug.cgi?id=131155 5 6 Reviewed by Andreas Kling. 7 8 The bug was caused by Chart.attach binding event listeners on plot container on each call. 9 This resulted in the click event handler toggling the visiblity of the tooltip twice upon 10 click when attach() has been called even number of times, keeping the tooltip invisible. 11 12 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as 13 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach 14 is called for the first time. 15 16 * public/index.html: 17 (Chart.attach): 18 (Chart..bindPlotEventHandlers): 19 1 20 2014-04-03 Ryosuke Niwa <rniwa@webkit.org> 2 21 -
trunk/Websites/perf.webkit.org/public/index.html
r166701 r166723 740 740 this.attachMainPlot(minTime); 741 741 742 var self = this; 743 742 if (bindPlotEventHandlers) 743 bindPlotEventHandlers(this); 744 bindPlotEventHandlers = null; 745 }; 746 747 function bindPlotEventHandlers(chart) { 744 748 // FIXME: Crosshair should stay where it was between charts. 745 749 $(plotContainer).bind("plothover", function (event, pos, item) { 746 750 for (var i = 0; i < charts.length; i++) { 747 if (charts[i] !== self) {751 if (charts[i] !== chart) { 748 752 charts[i].setCrosshair(pos); 749 753 charts[i].hideTooltip(); … … 783 787 }); 784 788 } 785 } ;786 789 } 790 787 791 charts.push(this); 788 792 }
Note: See TracChangeset
for help on using the changeset viewer.