Changeset 166724 in webkit
- Timestamp:
- Apr 3, 2014 9:39:11 AM (10 years ago)
- Location:
- trunk/Websites/perf.webkit.org
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Websites/perf.webkit.org/ChangeLog
r166723 r166724 1 2014-04-03 Ryosuke Niwa <rniwa@webkit.org> 2 3 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests 4 https://bugs.webkit.org/show_bug.cgi?id=131157 5 6 Reviewed by Andreas Kling. 7 8 Split "all metrics" into all metrics of a test suite and all subtests of the suite. 9 This allows, for example, adding all metrics such as Arithmetic and Geometric for 10 a given test suite without also adding its subtests. 11 12 * public/index.html: 13 (init.showCharts): 14 (init): 15 1 16 2014-04-03 Ryosuke Niwa <rniwa@webkit.org> 2 17 -
trunk/Websites/perf.webkit.org/public/index.html
r166723 r166724 955 955 metricList.removeChild(metricList.firstChild); 956 956 957 addOption(metricList, 'All metrics', OPTION_VALUE_FOR_ALL); 957 var metricsGroup = document.createElement('optgroup'); 958 metricsGroup.label = 'Metrics'; 959 metricList.appendChild(metricsGroup); 960 addOption(metricsGroup, 'All metrics', OPTION_VALUE_FOR_ALL); 958 961 for (var i = 0; i < tests.length; ++i) { 959 if (tests[i].id != testList.value && (!tests[i].parentTest || tests[i].parentTest.id != testList.value)) 962 if (tests[i].id == testList.value) { 963 var selectedTest = tests[i]; 964 for (var j = 0; j < selectedTest.metrics.length; ++j) { 965 var fullName = selectedTest.metrics[j].fullName; 966 var relativeName = fullName.replace(selectedTest.fullName, '').replace(/^[:/]/, ''); 967 addOption(metricsGroup, relativeName, fullName); 968 } 969 } 970 } 971 var subtestsGroup = document.createElement('optgroup'); 972 subtestsGroup.label = 'Tests'; 973 metricList.appendChild(subtestsGroup); 974 addOption(subtestsGroup, 'All subtests', OPTION_VALUE_FOR_ALL); 975 for (var i = 0; i < tests.length; ++i) { 976 if (!tests[i].parentTest || tests[i].parentTest.id != testList.value) 960 977 continue; 961 var selectedTest = tests[i].id == testList.value ? tests[i] : tests[i].parentTest; 962 for (var j = 0; j < tests[i].metrics.length; ++j) { 963 var fullName = tests[i].metrics[j].fullName; 978 var subtest = tests[i]; 979 var selectedTest = subtest.parentTest; 980 for (var j = 0; j < subtest.metrics.length; ++j) { 981 var fullName = subtest.metrics[j].fullName; 964 982 var relativeName = fullName.replace(selectedTest.fullName, '').replace(/^[:/]/, ''); 965 addOption( metricList, relativeName, fullName);983 addOption(subtestsGroup, relativeName, fullName); 966 984 } 967 985 } … … 1019 1037 } 1020 1038 } else if (metricList.value === OPTION_VALUE_FOR_ALL) { 1021 for (var i = 0; i < tests.length; ++i) { 1022 if (tests[i].id != testList.value && (!tests[i].parentTest || tests[i].parentTest.id != testList.value)) 1039 var group = metricList.selectedOptions[0].parentNode; 1040 var metricsToAdd = []; 1041 for (var i = 0; i < group.children.length; i++) { 1042 var metric = group.children[i].value; 1043 if (metric == OPTION_VALUE_FOR_ALL) 1023 1044 continue; 1024 for (var j = 0; j < tests[i].metrics.length; ++j) { 1025 createChartFromListPair(platformList.value, tests[i].metrics[j].fullName); 1026 newChartList.push([platformList.value, tests[i].metrics[j].fullName]); 1027 } 1045 createChartFromListPair(platformList.value, metric); 1046 newChartList.push([platformList.value, metric]); 1028 1047 } 1029 1048 } else {
Note: See TracChangeset
for help on using the changeset viewer.