Changeset 166745 in webkit

Timestamp:

Apr 3, 2014 2:40:49 PM (10 years ago)

Author:

hyatt@apple.com

Message:

REGRESSION: fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic.html broken
​https://bugs.webkit.org/show_bug.cgi?id=131183

Reviewed by Simon Fraser.

Revert the loop to continue rather than breaking when an invalid block is encountered.
This is what it used to do if it encountered a non-continuation block.

• rendering/RenderInline.cpp:

(WebCore::updateStyleOfAnonymousBlockContinuations):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderInline.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-03  David Hyatt  <hyatt@apple.com>
+
+        REGRESSION: fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic.html broken
+        https://bugs.webkit.org/show_bug.cgi?id=131183
+
+        Reviewed by Simon Fraser.
+
+        Revert the loop to continue rather than breaking when an invalid block is encountered.
+        This is what it used to do if it encountered a non-continuation block.
+
+        * rendering/RenderInline.cpp:
+        (WebCore::updateStyleOfAnonymousBlockContinuations):
+
 2014-04-02  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/rendering/RenderInline.cpp

@@ -151 +151 @@
         
         if (!box->isRenderBlock())
-            break; // We're done if we ever encounter something other than a RenderBlock.
+            continue;
 
         RenderBlock* block = toRenderBlock(box);
         if (!block->isAnonymousBlockContinuation())
-            break; // We're done if we ever encounter something other than a continuation RenderBlock.
+            continue;
         
         // If we are no longer in-flow positioned but our descendant block(s) still have an in-flow positioned ancestor then