Changeset 166751 in webkit

Timestamp:

Apr 3, 2014 3:56:47 PM (10 years ago)

Author:

akling@apple.com

Message:

Fix over-retain in SharedBufferCF's createCFData().
<​https://webkit.org/b/131139>

Constructing the return type (RetainPtr<CFDataRef>) will also retain
the pointee, so this would end up leaking.

Reviewed by Anders Carlsson.

• platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::createCFData):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/cf/SharedBufferCF.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-03  Andreas Kling  <akling@apple.com>
+
+        Fix over-retain in SharedBufferCF's createCFData().
+        <https://webkit.org/b/131139>
+
+        Constructing the return type (RetainPtr<CFDataRef>) will also retain
+        the pointee, so this would end up leaking.
+
+        Reviewed by Anders Carlsson.
+
+        * platform/cf/SharedBufferCF.cpp:
+        (WebCore::SharedBuffer::createCFData):
+
 2014-04-03  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebCore/platform/cf/SharedBufferCF.cpp

@@ -55 +55 @@
 RetainPtr<CFDataRef> SharedBuffer::createCFData()
 {
-    if (m_cfData) {
-        CFRetain(m_cfData.get());
-        return m_cfData.get();
-    }
+    if (m_cfData)
+        return m_cfData;
 
     // Internal data in SharedBuffer can be segmented. We need to get the contiguous buffer.