Changeset 166817 in webkit

Timestamp:

Apr 4, 2014 5:37:55 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

AX: supportsARIAExpanded should always return true for a few roles: combobox, disclosure.
​https://bugs.webkit.org/show_bug.cgi?id=129787

Patch by James Craig <​jcraig@apple.com> on 2014-04-04
Reviewed by Chris Fleizach.

Source/WebCore:

Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsARIAExpanded):

LayoutTests:

• inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
• inspector-protocol/dom/getAccessibilityPropertiesForNode.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-04-04  James Craig  <jcraig@apple.com>
+
+        AX: supportsARIAExpanded should always return true for a few roles: combobox, disclosure.
+        https://bugs.webkit.org/show_bug.cgi?id=129787
+
+        Reviewed by Chris Fleizach.
+
+        * inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
+        * inspector-protocol/dom/getAccessibilityPropertiesForNode.html:
+
 2014-04-04  Zoltan Horvath  <zoltan@webkit.org>
 

trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt

@@ -122 +122 @@
     role: combobox
     controlledNodeIds.length: 1
+    expanded: false
     focused: false
     ownedNodeIds.length: 1

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-04  James Craig  <jcraig@apple.com>
+
+        AX: supportsARIAExpanded should always return true for a few roles: combobox, disclosure.
+        https://bugs.webkit.org/show_bug.cgi?id=129787
+
+        Reviewed by Chris Fleizach.
+
+        Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
+
+        * accessibility/AccessibilityObject.cpp:
+        (WebCore::AccessibilityObject::supportsARIAExpanded):
+
 2014-04-04  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

@@ -1961 +1961 @@
     // Undefined values should not result in this attribute being exposed to ATs according to ARIA.
     const AtomicString& expanded = getAttribute(aria_expandedAttr);
-    return equalIgnoringCase(expanded, "true") || equalIgnoringCase(expanded, "false");
+    if (equalIgnoringCase(expanded, "true") || equalIgnoringCase(expanded, "false"))
+        return true;
+    switch (roleValue()) {
+    case ComboBoxRole:
+    case DisclosureTriangleRole:
+        return true;
+    default:
+        return false;
+    }
 }