Changeset 166866 in webkit

Timestamp:

Apr 6, 2014 10:24:42 PM (10 years ago)

Author:

gyuyoung.kim@samsung.com

Message:

[EFL][WK1] Apply std::unique_ptr<> to NavigatorContentUtilsClientEfl
​https://bugs.webkit.org/show_bug.cgi?id=130958

Reviewed by Darin Adler.

As a step of replacing OwnPtr with std::unique_ptr, this patch replaces
OwnPtr with the std::unique_ptr for NavigatorContentUtilsClientEfl.

• WebCoreSupport/NavigatorContentUtilsClientEfl.cpp:

(WebCore::NavigatorContentUtilsClientEfl::create): Deleted.

• WebCoreSupport/NavigatorContentUtilsClientEfl.h:
• ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/NavigatorContentUtilsClientEfl.cpp (modified) (1 diff)
• WebCoreSupport/NavigatorContentUtilsClientEfl.h (modified) (2 diffs)
• ewk/ewk_view.cpp (modified) (2 diffs)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2014-04-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        [EFL][WK1] Apply std::unique_ptr<> to NavigatorContentUtilsClientEfl
+        https://bugs.webkit.org/show_bug.cgi?id=130958
+
+        Reviewed by Darin Adler.
+
+        As a step of replacing OwnPtr with std::unique_ptr, this patch replaces
+        OwnPtr with the std::unique_ptr for NavigatorContentUtilsClientEfl.
+
+        * WebCoreSupport/NavigatorContentUtilsClientEfl.cpp:
+        (WebCore::NavigatorContentUtilsClientEfl::create): Deleted.
+        * WebCoreSupport/NavigatorContentUtilsClientEfl.h:
+        * ewk/ewk_view.cpp:
+        (_ewk_view_priv_new):
+
 2014-04-05  Ryuan Choi  <ryuan.choi@samsung.com>
 

trunk/Source/WebKit/efl/WebCoreSupport/NavigatorContentUtilsClientEfl.cpp

@@ -54 +54 @@
 }
 
-PassOwnPtr<NavigatorContentUtilsClientEfl> NavigatorContentUtilsClientEfl::create(Evas_Object* view)
-{
-    return adoptPtr(new NavigatorContentUtilsClientEfl(view));
-}
-
 NavigatorContentUtilsClientEfl::NavigatorContentUtilsClientEfl(Evas_Object* view)
     : m_view(view)

trunk/Source/WebKit/efl/WebCoreSupport/NavigatorContentUtilsClientEfl.h

@@ -37 +37 @@
 class NavigatorContentUtilsClientEfl : public WebCore::NavigatorContentUtilsClient {
 public:
-    static PassOwnPtr<NavigatorContentUtilsClientEfl> create(Evas_Object* view);
+    explicit NavigatorContentUtilsClientEfl(Evas_Object* view);
 
     ~NavigatorContentUtilsClientEfl() { }
@@ -49 +49 @@
 private:
     Evas_Object* m_view;
-
-    NavigatorContentUtilsClientEfl(Evas_Object* view);
 };
 }

trunk/Source/WebKit/efl/ewk/ewk_view.cpp

@@ -261 +261 @@
 #endif
 #if ENABLE(NAVIGATOR_CONTENT_UTILS) || ENABLE(CUSTOM_SCHEME_HANDLER)
-    OwnPtr<WebCore::NavigatorContentUtilsClientEfl> navigatorContentUtilsClient;
+    std::unique_ptr<WebCore::NavigatorContentUtilsClientEfl> navigatorContentUtilsClient;
 #endif
     struct {
@@ -688 +688 @@
 
 #if ENABLE(NAVIGATOR_CONTENT_UTILS)
-    priv->navigatorContentUtilsClient = WebCore::NavigatorContentUtilsClientEfl::create(smartData->self);
+    priv->navigatorContentUtilsClient = std::make_unique<WebCore::NavigatorContentUtilsClientEfl>(smartData->self);
     WebCore::provideNavigatorContentUtilsTo(priv->page.get(), priv->navigatorContentUtilsClient.get());
 #endif