Changeset 167012 in webkit


Ignore:
Timestamp:
Apr 9, 2014 8:08:17 AM (10 years ago)
Author:
mario.prada@samsung.com
Message:

[GTK] Layout tests accessibility/children-changed-sends-notification.html and accessibility/notification-listeners.html fails
​https://bugs.webkit.org/show_bug.cgi?id=131380

Reviewed by Chris Fleizach.

Source/WebCore:

Don't emit signals for added objects that we know won't be exposed
to the accessibility hierarchy (e.g. static text).

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::attachWrapper): Add extra check and early return.

LayoutTests:

Updated TestExpectations file and update layout test that was not
correctly written, and expecting the signals in the wrong order.

  • platform/gtk/TestExpectations: Removed failure expectations.
  • accessibility/children-changed-sends-notification.html: Updated

test to make sure we touch the accessibility tree after adding a
<button> so we get the 'add' signal at the right moment.

  • accessibility/children-changed-sends-notification-expected.txt:

Updated expectations to expect the 'add' and 'remove' signals in
the right order.

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r167011 r167012  
     12014-04-09  Mario Sanchez Prada  <mario.prada@samsung.com>
     2
     3        [GTK] Layout tests accessibility/children-changed-sends-notification.html and accessibility/notification-listeners.html fails
     4        https://bugs.webkit.org/show_bug.cgi?id=131380
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Updated TestExpectations file and update layout test that was not
     9        correctly written, and expecting the signals in the wrong order.
     10
     11        * platform/gtk/TestExpectations: Removed failure expectations.
     12
     13        * accessibility/children-changed-sends-notification.html: Updated
     14        test to make sure we touch the accessibility tree after adding a
     15        <button> so we get the 'add' signal at the right moment.
     16
     17        * accessibility/children-changed-sends-notification-expected.txt:
     18        Updated expectations to expect the 'add' and 'remove' signals in
     19        the right order.
     20
    1212014-04-09  Mario Sanchez Prada  <mario.prada@samsung.com>
    222

  • trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt

    r161966 r167012  
    77
    88End of test
     9PARAGRAPH notification: AXChildrenAdded
     10GLOBAL notification: AXChildrenAdded on element with role AXRole: AXParagraph
    911PARAGRAPH notification: AXChildrenRemoved
    1012GLOBAL notification: AXChildrenRemoved on element with role AXRole: AXParagraph
    11 PARAGRAPH notification: AXChildrenAdded
    12 GLOBAL notification: AXChildrenAdded on element with role AXRole: AXParagraph
    1313PASS paragraphNotificationCount is globalNotificationCount
    1414PASS globalNotificationCount is 2

  • trunk/LayoutTests/accessibility/children-changed-sends-notification.html

    r160903 r167012  
    5858    par.appendChild(newChild);
    5959
     60    // Ensure the new child is added.
     61    touchAccessibilityTree(axWebArea);
     62
    6063    window.setTimeout(function() {
    6164        var link = document.getElementById('testLink');

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r167011 r167012  
    10581058webkit.org/b/106340 accessibility/img-fallsback-to-title.html [ Failure ]
    10591059
    1060 webkit.org/b/131380 accessibility/children-changed-sends-notification.html [ Failure ]
    1061 webkit.org/b/131380 accessibility/notification-listeners.html [ Failure ]
    1062 
    10631060# svg/ failures
    10641061webkit.org/b/42457 svg/custom/embedded-svg-allowed-in-dashboard.xml [ Failure ]

  • trunk/Source/WebCore/ChangeLog

    r167011 r167012  
     12014-04-09  Mario Sanchez Prada  <mario.prada@samsung.com>
     2
     3        [GTK] Layout tests accessibility/children-changed-sends-notification.html and accessibility/notification-listeners.html fails
     4        https://bugs.webkit.org/show_bug.cgi?id=131380
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Don't emit signals for added objects that we know won't be exposed
     9        to the accessibility hierarchy (e.g. static text).
     10
     11        * accessibility/atk/AXObjectCacheAtk.cpp:
     12        (WebCore::AXObjectCache::attachWrapper): Add extra check and early return.
     13
    1142014-04-09  Mario Sanchez Prada  <mario.prada@samsung.com>
    215

  • trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp

    r166288 r167012  
    7777        return;
    7878
    79     // Don't emit the signal for objects that we already know won't be exposed directly.
     79    // Don't emit the signal when the actual object being added is not going to be exposed.
     80    if (obj->accessibilityIsIgnoredByDefault())
     81        return;
     82
     83    // Don't emit the signal for objects whose parents won't be exposed directly.
    8084    AccessibilityObject* coreParent = obj->parentObjectUnignored();
    8185    if (!coreParent || coreParent->accessibilityIsIgnoredByDefault())
Note: See TracChangeset for help on using the changeset viewer.