Changeset 167076 in webkit
- Timestamp:
- Apr 10, 2014 10:50:15 AM (10 years ago)
- Location:
- trunk/Source/JavaScriptCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r167061 r167076 1 2014-04-10 Mark Lam <mark.lam@apple.com> 2 3 LLINT loadisFromInstruction should handle the big endian case. 4 <https://webkit.org/b/131495> 5 6 Reviewed by Mark Hahnenberg. 7 8 The LLINT loadisFromInstruction macro aims to load the least significant 9 32-bit word from the 64-bit bytecode instruction stream and sign extend 10 it. For big endian machines, the current implementation would load the 11 wrong 32-bit word. 12 13 Without this fix, the JSC tests will crash on big endian machines. 14 Thanks to Tomas Popela for diagnosing this issue. 15 16 * llint/LowLevelInterpreter.asm: 17 1 18 2014-04-09 Mark Lam <mark.lam@apple.com> 2 19 -
trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.asm
r166392 r167076 107 107 108 108 macro loadisFromInstruction(offset, dest) 109 if BIG_ENDIAN 110 loadis 4 + offset * 8[PB, PC, 8], dest 111 else 109 112 loadis offset * 8[PB, PC, 8], dest 113 end 110 114 end 111 115
Note: See TracChangeset
for help on using the changeset viewer.