Changeset 167299 in webkit


Ignore:
Timestamp:
Apr 14, 2014 11:24:42 PM (10 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r167261.
​https://bugs.webkit.org/show_bug.cgi?id=131667

broke many navigation tests (Requested by ap on #webkit).

Reverted changeset:

"Web Replay: memoize fallback time values for
document.lastModified"
​https://bugs.webkit.org/show_bug.cgi?id=131318
​http://trac.webkit.org/changeset/167261

Location:
trunk
Files:
1 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r167297 r167299  
     12014-04-14  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r167261.
     4        https://bugs.webkit.org/show_bug.cgi?id=131667
     5
     6        broke many navigation tests (Requested by ap on #webkit).
     7
     8        Reverted changeset:
     9
     10        "Web Replay: memoize fallback time values for
     11        document.lastModified"
     12        https://bugs.webkit.org/show_bug.cgi?id=131318
     13        http://trac.webkit.org/changeset/167261
     14
    1152014-04-14  Commit Queue  <commit-queue@webkit.org>
    216

  • trunk/Source/WebCore/ChangeLog

    r167298 r167299  
     12014-04-14  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r167261.
     4        https://bugs.webkit.org/show_bug.cgi?id=131667
     5
     6        broke many navigation tests (Requested by ap on #webkit).
     7
     8        Reverted changeset:
     9
     10        "Web Replay: memoize fallback time values for
     11        document.lastModified"
     12        https://bugs.webkit.org/show_bug.cgi?id=131318
     13        http://trac.webkit.org/changeset/167261
     14
    1152014-04-14  Simon Fraser  <simon.fraser@apple.com>
    216

  • trunk/Source/WebCore/dom/Document.cpp

    r167261 r167299  
    221221
    222222#if ENABLE(WEB_REPLAY)
    223 #include "WebReplayInputs.h"
    224223#include <replay/EmptyInputCursor.h>
    225224#endif
    … …  
    38933892    // specificiation tells us to read the last modification date from the file
    38943893    // system.
    3895     if (!foundDate) {
    3896         double fallbackDate = currentTimeMS();
    3897 #if ENABLE(WEB_REPLAY)
    3898         InputCursor& cursor = inputCursor();
    3899         if (cursor.isCapturing())
    3900             cursor.appendInput<DocumentLastModifiedDate>(fallbackDate);
    3901         else if (cursor.isReplaying()) {
    3902             if (DocumentLastModifiedDate* input = cursor.fetchInput<DocumentLastModifiedDate>())
    3903                 fallbackDate = input->fallbackValue();
    3904         }
    3905 #endif
    3906         date.setMillisecondsSinceEpochForDateTime(fallbackDate);
    3907     }
    3908 
     3894    if (!foundDate)
     3895        date.setMillisecondsSinceEpochForDateTime(currentTimeMS());
    39093896    return String::format("%02d/%02d/%04d %02d:%02d:%02d", date.month() + 1, date.monthDay(), date.fullYear(), date.hour(), date.minute(), date.second());
    39103897}

  • trunk/Source/WebCore/replay/WebInputs.json

    r167261 r167299  
    166166        },
    167167        {
    168             "name": "DocumentLastModifiedDate",
    169             "description": "A fallback value used for the document's last modified date if the Last-Modified header can't be found or used.",
    170             "queue": "SCRIPT_MEMOIZED",
    171             "members": [
    172                 { "name": "fallbackValue", "type": "double" }
    173             ]
    174         },
    175         {
    176168            "name": "EndSegmentSentinel",
    177169            "description": "A sentinel input to signal the end of a segment.",
Note: See TracChangeset for help on using the changeset viewer.