Changeset 167439 in webkit


Ignore:
Timestamp:
Apr 17, 2014 10:53:40 AM (10 years ago)
Author:
hyatt@apple.com
Message:

[New Multicolumn] Column sets below spanners don't repaint properly.
https://bugs.webkit.org/show_bug.cgi?id=131778

Reviewed by Beth Dakin.

Source/WebCore:
Added fast/repaint/spanner-with-margins.html.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):
Turn off some code that was running for in-flow RenderFlowThreads that made no sense.
I'm not convinced the code is right for other types of RenderFlowThreads either,
but will leave that to the named flow thread experts. :)

LayoutTests:

  • fast/repaint/spanner-with-margin-expected.txt: Added.
  • fast/repaint/spanner-with-margin.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r167438 r167439  
     12014-04-17  David Hyatt  <hyatt@apple.com>
     2
     3        [New Multicolumn] Column sets below spanners don't repaint properly.
     4        https://bugs.webkit.org/show_bug.cgi?id=131778
     5
     6        Reviewed by Beth Dakin.
     7
     8        * fast/repaint/spanner-with-margin-expected.txt: Added.
     9        * fast/repaint/spanner-with-margin.html: Added.
     10
    1112014-04-17  Eduardo Lima Mitev  <elima@igalia.com>
    212
  • trunk/Source/WebCore/ChangeLog

    r167437 r167439  
     12014-04-17  David Hyatt  <hyatt@apple.com>
     2
     3        [New Multicolumn] Column sets below spanners don't repaint properly.
     4        https://bugs.webkit.org/show_bug.cgi?id=131778
     5
     6        Reviewed by Beth Dakin.
     7
     8        Added fast/repaint/spanner-with-margins.html.
     9
     10        * rendering/RenderBox.cpp:
     11        (WebCore::RenderBox::computeRectForRepaint):
     12        Turn off some code that was running for in-flow RenderFlowThreads that made no sense.
     13        I'm not convinced the code is right for other types of RenderFlowThreads either,
     14        but will leave that to the named flow thread experts. :)
     15
    1162014-04-17  Koji Ishii  <kojishi@gmail.com>
    217
  • trunk/Source/WebCore/rendering/RenderBox.cpp

    r167387 r167439  
    21082108    if (!o)
    21092109        return;
    2110 
    2111     if (o->isRenderFlowThread()) {
     2110   
     2111    // This code isn't necessary for in-flow RenderFlowThreads.
     2112    if (o->isOutOfFlowRenderFlowThread()) {
    21122113        RenderRegion* firstRegion = nullptr;
    21132114        RenderRegion* lastRegion = nullptr;
Note: See TracChangeset for help on using the changeset viewer.