Changeset 167508 in webkit

Timestamp:

Apr 18, 2014 2:03:23 PM (10 years ago)

Author:

Martin Robinson

Message:

Remove DynamicAnnotations.h?
​https://bugs.webkit.org/show_bug.cgi?id=131754

Reviewed by Simon Fraser.

This file, which helped support tools like Valgrind was unused.

• WTF.vcxproj/WTF.vcxproj: Remove references to the files.
• WTF.vcxproj/WTF.vcxproj.filters: Remove references to the files.
• WTF.xcodeproj/project.pbxproj: Remove references to the files.
• wtf/CMakeLists.txt: Remove references to the files.
• wtf/DynamicAnnotations.cpp: Removed.
• wtf/DynamicAnnotations.h: Removed.
• wtf/ThreadSafeRefCounted.h: Remove references to the files.
• wtf/text/StringStatics.cpp: Remove references to the files.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• WTF.vcxproj/WTF.vcxproj (modified) (2 diffs)
• WTF.vcxproj/WTF.vcxproj.filters (modified) (2 diffs)
• WTF.xcodeproj/project.pbxproj (modified) (5 diffs)
• wtf/CMakeLists.txt (modified) (2 diffs)
• wtf/DynamicAnnotations.cpp (deleted)
• wtf/DynamicAnnotations.h (deleted)
• wtf/ThreadSafeRefCounted.h (modified) (2 diffs)
• wtf/text/StringStatics.cpp (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2014-04-18  Martin Robinson  <mrobinson@igalia.com>
+
+        Remove DynamicAnnotations.h?
+        https://bugs.webkit.org/show_bug.cgi?id=131754
+
+        Reviewed by Simon Fraser.
+
+        This file, which helped support tools like Valgrind was unused.
+
+        * WTF.vcxproj/WTF.vcxproj: Remove references to the files.
+        * WTF.vcxproj/WTF.vcxproj.filters: Remove references to the files.
+        * WTF.xcodeproj/project.pbxproj: Remove references to the files.
+        * wtf/CMakeLists.txt: Remove references to the files.
+        * wtf/DynamicAnnotations.cpp: Removed.
+        * wtf/DynamicAnnotations.h: Removed.
+        * wtf/ThreadSafeRefCounted.h: Remove references to the files.
+        * wtf/text/StringStatics.cpp: Remove references to the files.
+
 2014-04-18  Philippe Normand  <pnormand@igalia.com>
 

trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj

@@ -71 +71 @@
     <ClCompile Include="..\wtf\dtoa\fixed-dtoa.cc" />
     <ClCompile Include="..\wtf\dtoa\strtod.cc" />
-    <ClCompile Include="..\wtf\DynamicAnnotations.cpp" />
     <ClCompile Include="..\wtf\FastBitVector.cpp" />
     <ClCompile Include="..\wtf\FastMalloc.cpp" />
@@ -195 +194 @@
     <ClInclude Include="..\wtf\dtoa\strtod.h" />
     <ClInclude Include="..\wtf\dtoa\utils.h" />
-    <ClInclude Include="..\wtf\DynamicAnnotations.h" />
     <ClInclude Include="..\wtf\Encoder.h" />
     <ClInclude Include="..\wtf\FastBitVector.h" />

trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters

@@ -133 +133 @@
       <Filter>wtf</Filter>
     </ClCompile>
-    <ClCompile Include="..\wtf\DynamicAnnotations.cpp">
-      <Filter>wtf</Filter>
-    </ClCompile>
     <ClCompile Include="..\wtf\FastMalloc.cpp">
       <Filter>wtf</Filter>
@@ -422 +419 @@
     </ClInclude>
     <ClInclude Include="..\wtf\DoublyLinkedList.h">
-      <Filter>wtf</Filter>
-    </ClInclude>
-    <ClInclude Include="..\wtf\DynamicAnnotations.h">
       <Filter>wtf</Filter>
     </ClInclude>

trunk/Source/WTF/WTF.xcodeproj/project.pbxproj

@@ -146 +146 @@
                 A8A473BA151A825B004123FF /* dtoa.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8A47297151A825A004123FF /* dtoa.cpp */; };
                 A8A473BB151A825B004123FF /* dtoa.h in Headers */ = {isa = PBXBuildFile; fileRef = A8A47298151A825A004123FF /* dtoa.h */; };
-                A8A473BC151A825B004123FF /* DynamicAnnotations.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8A47299151A825A004123FF /* DynamicAnnotations.cpp */; };
-                A8A473BD151A825B004123FF /* DynamicAnnotations.h in Headers */ = {isa = PBXBuildFile; fileRef = A8A4729A151A825A004123FF /* DynamicAnnotations.h */; };
                 A8A473C0151A825B004123FF /* Encoder.h in Headers */ = {isa = PBXBuildFile; fileRef = A8A4729E151A825A004123FF /* Encoder.h */; };
                 A8A473C1151A825B004123FF /* ExportMacros.h in Headers */ = {isa = PBXBuildFile; fileRef = A8A4729F151A825A004123FF /* ExportMacros.h */; };
@@ -438 +436 @@
                 A8A47297151A825A004123FF /* dtoa.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = dtoa.cpp; sourceTree = "<group>"; };
                 A8A47298151A825A004123FF /* dtoa.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = dtoa.h; sourceTree = "<group>"; };
-                A8A47299151A825A004123FF /* DynamicAnnotations.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DynamicAnnotations.cpp; sourceTree = "<group>"; };
-                A8A4729A151A825A004123FF /* DynamicAnnotations.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DynamicAnnotations.h; sourceTree = "<group>"; };
                 A8A4729E151A825A004123FF /* Encoder.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Encoder.h; sourceTree = "<group>"; };
                 A8A4729F151A825A004123FF /* ExportMacros.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ExportMacros.h; sourceTree = "<group>"; };
@@ -741 +737 @@
                                 A8A47297151A825A004123FF /* dtoa.cpp */,
                                 A8A47298151A825A004123FF /* dtoa.h */,
-                                A8A47299151A825A004123FF /* DynamicAnnotations.cpp */,
-                                A8A4729A151A825A004123FF /* DynamicAnnotations.h */,
                                 A8A4729E151A825A004123FF /* Encoder.h */,
                                 A8A4729F151A825A004123FF /* ExportMacros.h */,
@@ -1058 +1052 @@
                                 A8A473A7151A825B004123FF /* DoublyLinkedList.h in Headers */,
                                 A8A473BB151A825B004123FF /* dtoa.h in Headers */,
-                                A8A473BD151A825B004123FF /* DynamicAnnotations.h in Headers */,
                                 A8A473C0151A825B004123FF /* Encoder.h in Headers */,
                                 A8A473C1151A825B004123FF /* ExportMacros.h in Headers */,
@@ -1309 +1302 @@
                                 A8A473BA151A825B004123FF /* dtoa.cpp in Sources */,
                                 0F885E0F1845AEA900F1E3FA /* FastBitVector.cpp in Sources */,
-                                A8A473BC151A825B004123FF /* DynamicAnnotations.cpp in Sources */,
                                 A8A473B3151A825B004123FF /* fast-dtoa.cc in Sources */,
                                 A8A473C3151A825B004123FF /* FastMalloc.cpp in Sources */,

trunk/Source/WTF/wtf/CMakeLists.txt

@@ -25 +25 @@
     DisallowCType.h
     DoublyLinkedList.h
-    DynamicAnnotations.h
     Encoder.h
     FastMalloc.h
@@ -160 +159 @@
     DateMath.cpp
     DecimalNumber.cpp
-    DynamicAnnotations.cpp
     FastBitVector.cpp
     FastMalloc.cpp

trunk/Source/WTF/wtf/ThreadSafeRefCounted.h

@@ -61 +61 @@
 
 #include <atomic>
-#include <wtf/DynamicAnnotations.h>
 #include <wtf/FastMalloc.h>
 #include <wtf/Noncopyable.h>
@@ -95 +94 @@
     bool derefBase()
     {
-        WTF_ANNOTATE_HAPPENS_BEFORE(&m_refCount);
         if (--m_refCount <= 0) {
-            WTF_ANNOTATE_HAPPENS_AFTER(&m_refCount);
             return true;
         }

trunk/Source/WTF/wtf/text/StringStatics.cpp

@@ -31 +31 @@
 
 #include "AtomicString.h"
-#include "DynamicAnnotations.h"
 #include "MainThread.h"
 #include "NeverDestroyed.h"
@@ -46 +45 @@
 {
     static NeverDestroyed<StringImpl> emptyString(ConstructEmptyString);
-    WTF_ANNOTATE_BENIGN_RACE(&emptyString, "Benign race on StringImpl::emptyString reference counter");
     return &emptyString.get();
 }