Changeset 167534 in webkit


Ignore:
Timestamp:
Apr 19, 2014 10:04:52 AM (10 years ago)
Author:
Darin Adler
Message:

Assertion in WebPage::runModal accesses object after it may have been destroyed
https://bugs.webkit.org/show_bug.cgi?id=131875

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runModal): Ref the WebPage so it's still around so we can
check the m_isRunningModal flag.

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r167528 r167534  
     12014-04-19  Darin Adler  <darin@apple.com>
     2
     3        Assertion in WebPage::runModal accesses object after it may have been destroyed
     4        https://bugs.webkit.org/show_bug.cgi?id=131875
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * WebProcess/WebPage/WebPage.cpp:
     9        (WebKit::WebPage::runModal): Ref the WebPage so it's still around so we can
     10        check the m_isRunningModal flag.
     11
    1122014-04-18  Commit Queue  <commit-queue@webkit.org>
    213
  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

    r167523 r167534  
    36993699    m_isRunningModal = true;
    37003700    send(Messages::WebPageProxy::RunModal());
     3701#if !ASSERT_DISABLED
     3702    Ref<WebPage> protector(*this);
     3703#endif
    37013704    RunLoop::run();
    37023705    ASSERT(!m_isRunningModal);
Note: See TracChangeset for help on using the changeset viewer.