Changeset 167554 in webkit

Timestamp:

Apr 19, 2014 4:02:09 PM (10 years ago)

Author:

ggaren@apple.com

Message:

bmalloc: Improved alignment in LargeChunk
​https://bugs.webkit.org/show_bug.cgi?id=131895

Reviewed by Andreas Kling.

• bmalloc/Chunk.h:
• bmalloc/LargeChunk.h: Align to vmPageSize just like Chunk does.

Technically, the previous alignment was harmless, but I would prefer,
dear reader, not to have to explain the interlocking set of
circumstances that made it so.

Location:

trunk/Source/bmalloc

Files:

• ChangeLog (modified) (1 diff)
• bmalloc/Chunk.h (modified) (1 diff)
• bmalloc/LargeChunk.h (modified) (1 diff)

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2014-04-19  Geoffrey Garen  <ggaren@apple.com>
+
+        bmalloc: Improved alignment in LargeChunk
+        https://bugs.webkit.org/show_bug.cgi?id=131895
+
+        Reviewed by Andreas Kling.
+
+        * bmalloc/Chunk.h:
+        * bmalloc/LargeChunk.h: Align to vmPageSize just like Chunk does.
+        Technically, the previous alignment was harmless, but I would prefer,
+        dear reader, not to have to explain the interlocking set of
+        circumstances that made it so.
+
 2014-04-19  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/bmalloc/bmalloc/Chunk.h

@@ -63 +63 @@
 
     // Align to vmPageSize to avoid sharing physical pages with metadata.
-    // Otherwise, we'll confuse the scavenger into scavenging metadata.
-     alignas(vmPageSize) char m_memory[];
+    // Otherwise, we'll confuse the scavenger into trying to scavenge metadata.
+    alignas(vmPageSize) char m_memory[];
 };
 

trunk/Source/bmalloc/bmalloc/LargeChunk.h

@@ -65 +65 @@
 
     BoundaryTag m_boundaryTags[boundaryTagCount];
-    alignas(largeAlignment) char m_memory[];
+
+    // Align to vmPageSize to avoid sharing physical pages with metadata.
+    // Otherwise, we'll confuse the scavenger into trying to scavenge metadata.
+    alignas(vmPageSize) char m_memory[];
 };