Changeset 167578 in webkit

Timestamp:

Apr 20, 2014 9:28:20 PM (10 years ago)

Author:

Brent Fulgham

Message:

[Mac] Unable to select 'Off' or 'Auto' from track menu when tracks consist of unsupported track types
​https://bugs.webkit.org/show_bug.cgi?id=131908
<rdar://problem/15999882>

Reviewed by Eric Carlson.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setSelectedTextTrack): When the user selects 'Off', make sure the currently 'showing'
track is switched to 'disabled'.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-20  Brent Fulgham  <bfulgham@apple.com>
+
+        [Mac] Unable to select 'Off' or 'Auto' from track menu when tracks consist of unsupported track types
+        https://bugs.webkit.org/show_bug.cgi?id=131908
+        <rdar://problem/15999882>
+
+        Reviewed by Eric Carlson.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::setSelectedTextTrack): When the user selects 'Off', make sure the currently 'showing'
+        track is switched to 'disabled'.
+
 2014-04-20  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -3715 +3715 @@
                 track->setMode(TextTrack::showingKeyword());
         }
+    } else if (trackToSelect == TextTrack::captionMenuOffItem()) {
+        for (int i = 0, length = trackList->length(); i < length; ++i)
+            trackList->item(i)->setMode(TextTrack::disabledKeyword());
     }