Changeset 167582 in webkit

Timestamp:

Apr 20, 2014 10:21:45 PM (10 years ago)

Author:

Alan Bujtas

Message:

Subpixel rendering: RenderLayer's size is set using enclosingRect() which can result in cruft.
​https://bugs.webkit.org/show_bug.cgi?id=131468

Reviewed by Darin Adler.

Layers marked opaque may not paint edge pixels, when RenderLayer bounds are non-integral and
get device pixel snapped.
For details see this: ​https://trac.webkit.org/r159463

Source/WebCore:
Test: compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

• compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background-expected.html: Added.
• compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background-expected.html (added)
• LayoutTests/compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerBacking.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-04-20  Zalan Bujtas  <zalan@apple.com>
+
+        Subpixel rendering: RenderLayer's size is set using enclosingRect() which can result in cruft.
+        https://bugs.webkit.org/show_bug.cgi?id=131468
+
+        Reviewed by Darin Adler.
+
+        Layers marked opaque may not paint edge pixels, when RenderLayer bounds are non-integral and
+        get device pixel snapped.
+        For details see this: https://trac.webkit.org/r159463
+
+        * compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background-expected.html: Added.
+        * compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html: Added.
+
 2014-04-19  Darin Adler  <darin@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-20  Zalan Bujtas  <zalan@apple.com>
+
+        Subpixel rendering: RenderLayer's size is set using enclosingRect() which can result in cruft.
+        https://bugs.webkit.org/show_bug.cgi?id=131468
+
+        Reviewed by Darin Adler.
+
+        Layers marked opaque may not paint edge pixels, when RenderLayer bounds are non-integral and
+        get device pixel snapped.
+        For details see this: https://trac.webkit.org/r159463
+
+        Test: compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+
 2014-04-19  Darin Adler  <darin@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -713 +713 @@
 
     /*
-    * GraphicsLayer: device pixel positioned. Floored, enclosing rect.
+    * GraphicsLayer: device pixel positioned, enclosing rect.
     * RenderLayer: subpixel positioned.
     * Offset from renderer (GraphicsLayer <-> RenderLayer::renderer()): subpixel based offset.
@@ -731 +731 @@
     * localCompositingBounds: this RenderLayer relative to its renderer().
     * relativeCompositingBounds: this RenderLayer relative to its parent compositing layer.
-    * enclosingRelativeCompositingBounds: this RenderLayer relative to its parent but floored to device pixel position.
+    * enclosingRelativeCompositingBounds: this RenderLayer relative to its parent, device pixel enclosing.
     * rendererOffsetFromGraphicsLayer: RenderLayer::renderer()'s offset from its enclosing GraphicsLayer.
     * devicePixelOffsetFromRenderer: rendererOffsetFromGraphicsLayer's device pixel part. (6.9px -> 6.5px in case of 2x display)
@@ -824 +824 @@
         // For non-root layers, background is always painted by the primary graphics layer.
         ASSERT(!m_backgroundLayer);
-        bool hadSubpixelRounding = !m_devicePixelFractionFromRenderer.isZero();
+        bool hadSubpixelRounding = enclosingRelativeCompositingBounds != relativeCompositingBounds;
         m_graphicsLayer->setContentsOpaque(!hadSubpixelRounding && m_owningLayer.backgroundIsKnownToBeOpaqueInRect(localCompositingBounds));
     }