Changeset 167656 in webkit

Timestamp:

Apr 22, 2014 6:36:21 AM (10 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Crash after getting web view context property with g_object_get
​https://bugs.webkit.org/show_bug.cgi?id=131983

Reviewed by Philippe Normand.

The problem is that the getter is using g_value_take_object() and
the default context is destroyed when the caller releases its ref.

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewGetProperty): Use g_value_set_object() instead of
g_value_take_object().

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitWebView.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Crash after getting web view context property with g_object_get
+        https://bugs.webkit.org/show_bug.cgi?id=131983
+
+        Reviewed by Philippe Normand.
+
+        The problem is that the getter is using g_value_take_object() and
+        the default context is destroyed when the caller releases its ref.
+
+        * UIProcess/API/gtk/WebKitWebView.cpp:
+        (webkitWebViewGetProperty): Use g_value_set_object() instead of
+        g_value_take_object().
+
 2014-04-22  Ryuan Choi  <ryuan.choi@samsung.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp

@@ -561 +561 @@
     switch (propId) {
     case PROP_WEB_CONTEXT:
-        g_value_take_object(value, webView->priv->context);
+        g_value_set_object(value, webView->priv->context);
         break;
     case PROP_GROUP: