Changeset 167659 in webkit

Timestamp:

Apr 22, 2014 7:17:43 AM (10 years ago)

Author:

Alan Bujtas

Message:

border-style: double rendered as solid when combined with border-radius
​https://bugs.webkit.org/show_bug.cgi?id=131927

Reviewed by Simon Fraser.

BorderEdge::getDoubleBorderStripeWidths() should return the calculated inner, outer border widths.

Source/WebCore:
Test: fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html

• rendering/BorderEdge.cpp:

(WebCore::BorderEdge::getDoubleBorderStripeWidths):

• rendering/BorderEdge.h:

LayoutTests:

• fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line-expected.html: Added.
• fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line-expected.html (added)
• LayoutTests/fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/BorderEdge.cpp (modified) (1 diff)
• Source/WebCore/rendering/BorderEdge.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-04-22  Zalan Bujtas  <zalan@apple.com>
+
+        border-style: double rendered as solid when combined with border-radius
+        https://bugs.webkit.org/show_bug.cgi?id=131927
+
+        Reviewed by Simon Fraser.
+
+        BorderEdge::getDoubleBorderStripeWidths() should return the calculated inner, outer border widths. 
+
+        * fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line-expected.html: Added.
+        * fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html: Added.
+
 2014-04-22  Manuel Rego Casasnovas  <rego@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-22  Zalan Bujtas  <zalan@apple.com>
+
+        border-style: double rendered as solid when combined with border-radius
+        https://bugs.webkit.org/show_bug.cgi?id=131927
+
+        Reviewed by Simon Fraser.
+
+        BorderEdge::getDoubleBorderStripeWidths() should return the calculated inner, outer border widths. 
+
+        Test: fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html
+
+        * rendering/BorderEdge.cpp:
+        (WebCore::BorderEdge::getDoubleBorderStripeWidths):
+        * rendering/BorderEdge.h:
+
 2014-04-22  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/rendering/BorderEdge.cpp

@@ -96 +96 @@
 }
 
-void BorderEdge::getDoubleBorderStripeWidths(LayoutUnit outerWidth, LayoutUnit innerWidth) const
+void BorderEdge::getDoubleBorderStripeWidths(LayoutUnit& outerWidth, LayoutUnit& innerWidth) const
 {
     LayoutUnit fullWidth = widthForPainting();

trunk/Source/WebCore/rendering/BorderEdge.h

@@ -60 +60 @@
     inline bool presentButInvisible() const { return widthForPainting() && !hasVisibleColorAndStyle(); }
     inline float widthForPainting() const { return m_isPresent ?  m_flooredToDevicePixelWidth : 0; }
-    void getDoubleBorderStripeWidths(LayoutUnit outerWidth, LayoutUnit innerWidth) const;
+    void getDoubleBorderStripeWidths(LayoutUnit& outerWidth, LayoutUnit& innerWidth) const;
     bool obscuresBackgroundEdge(float scale) const;
     bool obscuresBackground() const;