Changeset 167661 in webkit
- Timestamp:
- Apr 22, 2014 8:39:26 AM (10 years ago)
- Location:
- trunk/Source/WebKit/efl
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/efl/ChangeLog
r167488 r167661 1 2014-04-22 Ryuan Choi <ryuan.choi@samsung.com> 2 3 [EFL][WK1] There are many warnings in layout test since r167428 4 https://bugs.webkit.org/show_bug.cgi?id=131985 5 6 Reviewed by Gyuyoung Kim. 7 8 Since r167428, implementation of flush method was removed, but ewk_view_frame_main_cleared 9 still checked and generated many warnings. 10 11 Now, ewk_view_frame_main_cleared is not required because flush is already 12 meaningless and others are covered by ewk_frame_view_create_for_view. 13 So, this patch removed ewk_view_frame_main_cleared and related code which is already dead. 14 15 * WebCoreSupport/FrameLoaderClientEfl.cpp: 16 (WebCore::FrameLoaderClientEfl::transitionToCommittedForNewPage): 17 * ewk/ewk_view.cpp: 18 (ewk_view_frame_main_cleared): Deleted. 19 (ewk_view_did_first_visually_nonempty_layout): Deleted. 20 (ewk_view_dispatch_did_finish_loading): Deleted. 21 * ewk/ewk_view.h: Removed flush smart method. 22 1 23 2014-04-18 Philippe Normand <pnormand@igalia.com> 2 24 -
trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp
r167185 r167661 994 994 995 995 ewk_frame_view_create_for_view(m_frame, m_view); 996 997 if (isLoadingMainFrame())998 ewk_view_frame_main_cleared(m_view);999 996 } 1000 997 -
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
r167488 r167661 2790 2790 /** 2791 2791 * @internal 2792 * Reports the main frame was cleared.2793 *2794 * @param ewkView View.2795 */2796 void ewk_view_frame_main_cleared(Evas_Object* ewkView)2797 {2798 DBG("ewkView=%p", ewkView);2799 EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData);2800 EINA_SAFETY_ON_NULL_RETURN(smartData->api->flush);2801 smartData->api->flush(smartData);2802 2803 ewk_view_mixed_content_displayed_set(ewkView, false);2804 ewk_view_mixed_content_run_set(ewkView, false);2805 }2806 2807 /**2808 * @internal2809 2792 * Reports the main frame received an icon. 2810 2793 * … … 3650 3633 } 3651 3634 3652 void ewk_view_did_first_visually_nonempty_layout(Evas_Object* ewkView)3653 {3654 EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData);3655 EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv);3656 if (!priv->flags.viewCleared) {3657 ewk_view_frame_main_cleared(ewkView);3658 ewk_view_enable_render(ewkView);3659 priv->flags.viewCleared = true;3660 }3661 }3662 3663 /**3664 * @internal3665 * Dispatch finished loading.3666 *3667 * @param ewkView view.3668 */3669 void ewk_view_dispatch_did_finish_loading(Evas_Object* ewkView)3670 {3671 /* If we reach this point and rendering is still disabled, WebCore will not3672 * trigger the didFirstVisuallyNonEmptyLayout signal anymore. So, we3673 * forcefully re-enable the rendering.3674 */3675 ewk_view_did_first_visually_nonempty_layout(ewkView);3676 }3677 3678 3635 void ewk_view_transition_to_commited_for_newpage(Evas_Object* ewkView) 3679 3636 { -
trunk/Source/WebKit/efl/ewk/ewk_view.h
r167342 r167661 156 156 Eina_Bool (*zoom_weak_set)(Ewk_View_Smart_Data *sd, float zoom, Evas_Coord cx, Evas_Coord cy); 157 157 void (*zoom_weak_smooth_scale_set)(Ewk_View_Smart_Data *sd, Eina_Bool smooth_scale); 158 void (*flush)(Ewk_View_Smart_Data *sd);159 158 Eina_Bool (*disable_render)(Ewk_View_Smart_Data *sd); 160 159 Eina_Bool (*enable_render)(Ewk_View_Smart_Data *sd); … … 205 204 * @see EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION 206 205 */ 207 #define EWK_VIEW_SMART_CLASS_INIT(smart_class_init) {smart_class_init, EWK_VIEW_SMART_CLASS_VERSION, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 , 0}206 #define EWK_VIEW_SMART_CLASS_INIT(smart_class_init) {smart_class_init, EWK_VIEW_SMART_CLASS_VERSION, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} 208 207 209 208 /**
Note: See TracChangeset
for help on using the changeset viewer.