Changeset 167722 in webkit

Timestamp:

Apr 23, 2014 2:22:53 PM (10 years ago)

Author:

akling@apple.com

Message:

[iOS] Memory pressure notification should fire on main thread.
<​https://webkit.org/b/132074>

Rejig the memory pressure notification to fire on the main queue
directly instead of rerouting it manually.

Reviewed by Mark Rowe.

• platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::install):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/cocoa/MemoryPressureHandlerCocoa.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-23  Andreas Kling  <akling@apple.com>
+
+        [iOS] Memory pressure notification should fire on main thread.
+        <https://webkit.org/b/132074>
+
+        Rejig the memory pressure notification to fire on the main queue
+        directly instead of rerouting it manually.
+
+        Reviewed by Mark Rowe.
+
+        * platform/cocoa/MemoryPressureHandlerCocoa.mm:
+        (WebCore::MemoryPressureHandler::install):
+
 2014-04-23  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm

@@ -82 +82 @@
     dispatch_async(dispatch_get_main_queue(), ^{
 #if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 80000
-        _cache_event_source = dispatch_source_create(DISPATCH_SOURCE_TYPE_MEMORYSTATUS, 0, DISPATCH_MEMORYSTATUS_PRESSURE_WARN, dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0));
+        _cache_event_source = dispatch_source_create(DISPATCH_SOURCE_TYPE_MEMORYSTATUS, 0, DISPATCH_MEMORYSTATUS_PRESSURE_WARN, dispatch_get_main_queue());
 #elif PLATFORM(MAC) && MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
         _cache_event_source = wkCreateMemoryStatusPressureCriticalDispatchOnMainQueue();
@@ -91 +91 @@
             dispatch_set_context(_cache_event_source, this);
             dispatch_source_set_event_handler(_cache_event_source, ^{
-                dispatch_async(dispatch_get_main_queue(), ^{
-                    memoryPressureHandler().respondToMemoryPressure();
-                });
+                memoryPressureHandler().respondToMemoryPressure();
             });
             dispatch_resume(_cache_event_source);