Changeset 167756 in webkit


Ignore:
Timestamp:
Apr 24, 2014 7:37:15 AM (10 years ago)
Author:
graouts@webkit.org
Message:

Web Inspector: gradient editor does not appear for linear-gradient with no specified angle
https://bugs.webkit.org/show_bug.cgi?id=132083

Reviewed by Timothy Hatcher.

Only assume we're parsing a legacy-formatted gradient if the first parameter is not a color.

  • UserInterface/Models/Gradient.js:

(WebInspector.LinearGradient.linearGradientWithComponents):

Location:
trunk/Source/WebInspectorUI
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r167685 r167756  
     12014-04-24  Antoine Quint  <graouts@webkit.org>
     2
     3        Web Inspector: gradient editor does not appear for linear-gradient with no specified angle
     4        https://bugs.webkit.org/show_bug.cgi?id=132083
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        Only assume we're parsing a legacy-formatted gradient if the first parameter is not a color.
     9
     10        * UserInterface/Models/Gradient.js:
     11        (WebInspector.LinearGradient.linearGradientWithComponents):
     12
    1132014-04-22  Brent Fulgham  <bfulgham@apple.com>
    214
  • trunk/Source/WebInspectorUI/UserInterface/Models/Gradient.js

    r165017 r167756  
    189189        }
    190190        components.shift();
    191     } else {
    192         // We don't support any of the legacy linear gradient formats.
     191    } else if (components[0].length !== 1 && !WebInspector.Color.fromString(components[0][0])) {
     192        // If the first component is not a color, then we're dealing with a
     193        // legacy linear gradient format that we don't support.
    193194        return null;
    194195    }
Note: See TracChangeset for help on using the changeset viewer.