Changeset 167761 in webkit

Timestamp:

Apr 24, 2014 9:27:38 AM (10 years ago)

Author:

tgergely.u-szeged@partner.samsung.com

Message:

ASSERTION FAILED: !begin.isIndefinite() in WebCore::SVGSMILElement::resolveFirstInterval.
​https://bugs.webkit.org/show_bug.cgi?id=131097

Reviewed by Darin Adler.

Source/WebCore:
According to smil animation reference, max attribute cannot be 0.

Test: svg/animations/smil-animation-max-attribute-zero-crash.svg

• svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::maxValue):

changed (result < 0) to (result <= 0)

LayoutTests:
Test added.

• svg/animations/smil-animation-max-attribute-zero-crash-expected.txt: Added.
• svg/animations/smil-animation-max-attribute-zero-crash.svg: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/animations/smil-animation-max-attribute-zero-crash-expected.txt (added)
• LayoutTests/svg/animations/smil-animation-max-attribute-zero-crash.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/animation/SVGSMILElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-04-24  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
+
+        ASSERTION FAILED: !begin.isIndefinite() in WebCore::SVGSMILElement::resolveFirstInterval.
+        https://bugs.webkit.org/show_bug.cgi?id=131097
+
+        Reviewed by Darin Adler.
+
+        Test added.
+
+        * svg/animations/smil-animation-max-attribute-zero-crash-expected.txt: Added.
+        * svg/animations/smil-animation-max-attribute-zero-crash.svg: Added.
+
 2014-04-24  Krzysztof Wolanski  <k.wolanski@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-24  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
+
+        ASSERTION FAILED: !begin.isIndefinite() in WebCore::SVGSMILElement::resolveFirstInterval.
+        https://bugs.webkit.org/show_bug.cgi?id=131097
+
+        Reviewed by Darin Adler.
+
+        According to smil animation reference, max attribute cannot be 0.
+
+        Test: svg/animations/smil-animation-max-attribute-zero-crash.svg
+
+        * svg/animation/SVGSMILElement.cpp:
+        (WebCore::SVGSMILElement::maxValue):
+          changed (result < 0) to (result <= 0)
+
 2014-04-24  Ryuan Choi  <ryuan.choi@samsung.com>
 

trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp

@@ -681 +681 @@
     const AtomicString& value = fastGetAttribute(SVGNames::maxAttr);
     SMILTime result = parseClockValue(value);
-    return m_cachedMax = (result.isUnresolved() || result < 0) ? SMILTime::indefinite() : result;
+    return m_cachedMax = (result.isUnresolved() || result <= 0) ? SMILTime::indefinite() : result;
 }