Changeset 167792 in webkit

Timestamp:

Apr 24, 2014 11:28:33 PM (10 years ago)

Author:

akling@apple.com

Message:

[iOS WebKit2] RemoteLayerTreeDrawingArea should force CA to garbage collect surfaces.
<​https://webkit.org/b/132160>
<rdar://problem/16110687>

Do an empty CATransaction at the end of RemoteLayerTreeDrawingArea::flushLayers()
to get CA to garbage collect its IOSurfaces. This helps clean up unused surfaces
that we'd otherwise end up hanging on to for a long time.

Reviewed by Tim Horton.

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::didUpdate):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-04-24  Andreas Kling  <akling@apple.com>
+
+        [iOS WebKit2] RemoteLayerTreeDrawingArea should force CA to garbage collect surfaces.
+        <https://webkit.org/b/132160>
+        <rdar://problem/16110687>
+
+        Do an empty CATransaction at the end of RemoteLayerTreeDrawingArea::flushLayers()
+        to get CA to garbage collect its IOSurfaces. This helps clean up unused surfaces
+        that we'd otherwise end up hanging on to for a long time.
+
+        Reviewed by Tim Horton.
+
+        * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
+        (WebKit::RemoteLayerTreeDrawingArea::didUpdate):
+
 2014-04-24  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm

@@ -43 +43 @@
 #import <WebCore/Settings.h>
 #import <WebCore/TiledBacking.h>
+#import <QuartzCore/QuartzCore.h>
 
 using namespace WebCore;
@@ -296 +297 @@
         m_hadFlushDeferredWhileWaitingForBackingStoreSwap = false;
     }
+
+    // This empty transaction serves to trigger CA's garbage collection of IOSurfaces. See <rdar://problem/16110687>
+    [CATransaction begin];
+    [CATransaction commit];
 }