Changeset 167796 in webkit

Timestamp:

Apr 25, 2014 1:04:28 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Incomplete body painting when using blend modes
​https://bugs.webkit.org/show_bug.cgi?id=131889

Source/WebCore:
The incomplete painting was caused by the transparency layer created for
the root renderer. We can safely skip creating this transparency layer at
the root level, as there is nothing else being painted behind this layer that
could be used erroneously as a backdrop.

Patch by Ion Rosca <Ion Rosca> on 2014-04-25
Reviewed by Simon Fraser.

Test: css3/compositing/blend-mode-with-body.html

• rendering/RenderLayer.h:

Changing RenderLayer::paintsWithTransparency so that it will not
return true when the root renderer needs to isolate blending.

LayoutTests:
Patch by Ion Rosca <Ion Rosca> on 2014-04-25
Reviewed by Simon Fraser.

• css3/compositing/blend-mode-with-body-expected.html: Added.
• css3/compositing/blend-mode-with-body.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css3/compositing/blend-mode-with-body-expected.html (added)
• LayoutTests/css3/compositing/blend-mode-with-body.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayer.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-04-25  Ion Rosca  <rosca@adobe.com>
+
+        Incomplete body painting when using blend modes
+        https://bugs.webkit.org/show_bug.cgi?id=131889
+
+        Reviewed by Simon Fraser.
+
+        * css3/compositing/blend-mode-with-body-expected.html: Added.
+        * css3/compositing/blend-mode-with-body.html: Added.
+
 2014-04-24  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-25  Ion Rosca  <rosca@adobe.com>
+
+        Incomplete body painting when using blend modes
+        https://bugs.webkit.org/show_bug.cgi?id=131889
+
+        The incomplete painting was caused by the transparency layer created for
+        the root renderer. We can safely skip creating this transparency layer at
+        the root level, as there is nothing else being painted behind this layer that
+        could be used erroneously as a backdrop.
+
+        Reviewed by Simon Fraser.
+
+        Test: css3/compositing/blend-mode-with-body.html
+
+        * rendering/RenderLayer.h:
+        Changing RenderLayer::paintsWithTransparency so that it will not
+        return true when the root renderer needs to isolate blending.
+
 2014-04-25  Darin Adler  <darin@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayer.h

@@ -834 +834 @@
     bool paintsWithTransparency(PaintBehavior paintBehavior) const
     {
-        return (isTransparent() || hasBlendMode() || isolatesBlending()) && ((paintBehavior & PaintBehaviorFlattenCompositingLayers) || !isComposited());
+        return (isTransparent() || hasBlendMode() || (isolatesBlending() && !renderer().isRoot())) && ((paintBehavior & PaintBehaviorFlattenCompositingLayers) || !isComposited());
     }