Changeset 167807 in webkit

Timestamp:

Apr 25, 2014 8:27:55 AM (10 years ago)

Author:

Brent Fulgham

Message:

ScrollingCoordinator is unaware of topContentInset
​https://bugs.webkit.org/show_bug.cgi?id=132158
<rdar://problem/16706152>

Reviewed by Darin Adler.

Source/WebCore:
Test: platform/mac/fast/scrolling/scroll-select-bottom-test.html

The calculation of non-fast-scrollable regions does not currently take
the topContentOffset into account. Consequently, the logic that decides
whether to stay on the scrolling thread, or drop down to an individual
page element, can make the wrong choice. This is especially true for
small scrollable regions (such as <select> elements), where the
topContentInset may be quite close to the size of the scrollable

element itself.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion): Also
include the topContentInset value in our calculation.

LayoutTests:

• platform/mac/fast/scrolling/scroll-select-bottom-test-expected.txt: Added.
• platform/mac/fast/scrolling/scroll-select-bottom-test.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/fast/scrolling/scroll-select-bottom-test-expected.txt (added)
• LayoutTests/platform/mac/fast/scrolling/scroll-select-bottom-test.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-04-25  Brent Fulgham  <bfulgham@apple.com>
+
+        ScrollingCoordinator is unaware of topContentInset
+        https://bugs.webkit.org/show_bug.cgi?id=132158
+        <rdar://problem/16706152>
+
+        Reviewed by Darin Adler.
+
+        * platform/mac/fast/scrolling/scroll-select-bottom-test-expected.txt: Added.
+        * platform/mac/fast/scrolling/scroll-select-bottom-test.html: Added.
+
 2014-04-25  Miyoung Shin  <myid.shin@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-25  Brent Fulgham  <bfulgham@apple.com>
+
+        ScrollingCoordinator is unaware of topContentInset
+        https://bugs.webkit.org/show_bug.cgi?id=132158
+        <rdar://problem/16706152>
+
+        Reviewed by Darin Adler.
+
+        Test: platform/mac/fast/scrolling/scroll-select-bottom-test.html
+
+        The calculation of non-fast-scrollable regions does not currently take
+        the topContentOffset into account. Consequently, the logic that decides
+        whether to stay on the scrolling thread, or drop down to an individual
+        page element, can make the wrong choice. This is especially true for
+        small scrollable regions (such as <select> elements), where the
+        topContentInset may be quite close to the size of the scrollable
+         element itself.
+
+        * page/scrolling/ScrollingCoordinator.cpp:
+        (WebCore::ScrollingCoordinator::computeNonFastScrollableRegion): Also
+        include the topContentInset value in our calculation.
+
 2014-04-25  Javier Fernandez  <jfernandez@igalia.com>
 

trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp

@@ -125 +125 @@
     IntPoint offset = frameLocation;
     offset.moveBy(frameView->frameRect().location());
+    offset.move(0, frameView->topContentInset());
 
     if (const FrameView::ScrollableAreaSet* scrollableAreas = frameView->scrollableAreas()) {