Changeset 167834 in webkit

Timestamp:

Apr 25, 2014 4:48:10 PM (10 years ago)

Author:

jcraig@apple.com

Message:

Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
​https://bugs.webkit.org/show_bug.cgi?id=132209

Reviewed by Daniel Bates.

Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
Run check-webkit-style before generating changelogs to avoid additional spurious errors.

• Scripts/prepare-ChangeLog:

(main):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/prepare-ChangeLog (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-04-25  James Craig  <jcraig@apple.com>
+
+        Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
+        https://bugs.webkit.org/show_bug.cgi?id=132209
+
+        Reviewed by Daniel Bates.
+
+        Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
+        Run check-webkit-style before generating changelogs to avoid additional spurious errors.
+
+        * Scripts/prepare-ChangeLog:
+        (main): 
+
 2014-04-25  Michael Saboff  <msaboff@apple.com>
 

trunk/Tools/Scripts/prepare-ChangeLog

@@ -129 +129 @@
     my $gitIndex = "";
     my $gitReviewer = "";
-    my $checkWebKitStyle = 1;
+    my $checkWebKitStyle;
     my $openChangeLogs = 0;
     my $writeChangeLogs = 1;
@@ -169 +169 @@
     }
 
+    if ($checkWebKitStyle) {
+        print STDERR "  Running check-webkit-style.\n  ";
+        system "$FindBin::Bin/check-webkit-style";
+    }
+
     die "--git-commit and --git-index are incompatible." if ($gitIndex && $gitCommit);
 
@@ -228 +233 @@
         printDiff($changedFiles, $gitCommit, $gitIndex, $mergeBase);
     }
-
-    if ($checkWebKitStyle) {
-        print STDERR "  Running check-webkit-style.\n  ";
-        system "$FindBin::Bin/check-webkit-style";
-    }  
 
     # Open ChangeLogs.