Changeset 168145 in webkit

Timestamp:

May 1, 2014 8:31:43 PM (10 years ago)

Author:

beidson@apple.com

Message:

Update service picker API usage.
<rdar://problem/16772674> and ​https://bugs.webkit.org/show_bug.cgi?id=132452

Reviewed by Tim Horton.

• Misc/WebSharingServicePickerController.h:
• Misc/WebSharingServicePickerController.mm:

(-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):

Factor out a common "didShare" handler that optionally validates whether the data represents an image.

(-[WebSharingServicePickerController sharingService:didShareItems:]): Update API usage, including marshalling

on off-main thread call back to the main thread.

• WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::contextMenuForEvent): Update API usage.

Location:

trunk/Source/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• Misc/WebSharingServicePickerController.h (modified) (1 diff)
• Misc/WebSharingServicePickerController.mm (modified) (4 diffs)
• WebCoreSupport/WebContextMenuClient.mm (modified) (2 diffs)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2014-05-01  Brady Eidson  <beidson@apple.com>
+
+        Update service picker API usage.
+        <rdar://problem/16772674> and https://bugs.webkit.org/show_bug.cgi?id=132452
+
+        Reviewed by Tim Horton.
+
+        * Misc/WebSharingServicePickerController.h:
+        * Misc/WebSharingServicePickerController.mm:
+        (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
+          Factor out a common "didShare" handler that optionally validates whether the data represents an image.
+        (-[WebSharingServicePickerController sharingService:didShareItems:]): Update API usage, including marshalling
+          on off-main thread call back to the main thread.
+
+        * WebCoreSupport/WebContextMenuClient.mm:
+        (WebContextMenuClient::contextMenuForEvent): Update API usage.
+
 2014-05-01  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit/mac/Misc/WebSharingServicePickerController.h

@@ -40 +40 @@
 }
 
-- (instancetype)initWithImage:(NSImage *)image includeEditorServices:(BOOL)includeEditorServices menuClient:(WebContextMenuClient*)menuClient;
+- (instancetype)initWithData:(NSData *)data includeEditorServices:(BOOL)includeEditorServices menuClient:(WebContextMenuClient*)menuClient;
 - (NSMenu *)menu;
+- (void)didShareImageData:(NSData *)data confirmDataIsValidTIFFData:(BOOL)confirmData;
 
 @end

trunk/Source/WebKit/mac/Misc/WebSharingServicePickerController.mm

@@ -50 +50 @@
 - (NSMenu *)menu;
 @end
-
 #endif
 
+#if __has_include(<AppKit/NSItemProvider.h>)
+#import <AppKit/NSItemProvider.h>
+#else
+@interface NSItemProvider : NSObject
+@property (copy, readonly) NSArray *registeredTypeIdentifiers;
+- (instancetype)initWithItem:(id <NSSecureCoding>)item typeIdentifier:(NSString *)typeIdentifier;
+- (void)loadItemForTypeIdentifier:(NSString *)typeIdentifier options:(NSDictionary *)options completionHandler:(void (^)(id <NSSecureCoding> item, NSError *error))completionHandler;
+@end
+#endif
+
 static NSString *serviceControlsPasteboardName = @"WebKitServiceControlsPasteboard";
 
@@ -59 +68 @@
 @implementation WebSharingServicePickerController
 
-- (instancetype)initWithImage:(NSImage *)image includeEditorServices:(BOOL)includeEditorServices menuClient:(WebContextMenuClient*)menuClient
+- (instancetype)initWithData:(NSData *)data includeEditorServices:(BOOL)includeEditorServices menuClient:(WebContextMenuClient*)menuClient
 {
     if (!(self = [super init]))
         return nil;
 
-    _picker = adoptNS([[NSSharingServicePicker alloc] initWithItems:@[ image ]]);
+    RetainPtr<NSItemProvider> itemProvider = adoptNS([[NSItemProvider alloc] initWithItem:data typeIdentifier:@"public.data"]);
+
+    _picker = adoptNS([[NSSharingServicePicker alloc] initWithItems:@[ itemProvider.get() ]]);
     [_picker setStyle:NSSharingServicePickerStyleRollover];
     [_picker setDelegate:self];
@@ -87 +98 @@
 }
 
+- (void)didShareImageData:(NSData *)data confirmDataIsValidTIFFData:(BOOL)confirmData
+{
+    Page* page = [_menuClient->webView() page];
+    if (!page)
+        return;
+
+    if (confirmData) {
+        RetainPtr<NSImage> nsImage = adoptNS([[NSImage alloc] initWithData:data]);
+        if (!nsImage) {
+            LOG_ERROR("Shared image data cannot create a valid NSImage");
+            return;
+        }
+
+        data = [nsImage TIFFRepresentation];
+    }
+
+    NSPasteboard *pasteboard = [NSPasteboard pasteboardWithName:serviceControlsPasteboardName];
+    [pasteboard declareTypes:@[ NSPasteboardTypeTIFF ] owner:nil];
+    [pasteboard setData:data forType:NSPasteboardTypeTIFF];
+
+    Frame& frame = page->focusController().focusedOrMainFrame();
+    if (!frame.selection().isNone())
+        frame.editor().readSelectionFromPasteboard(serviceControlsPasteboardName);
+
+    [self clear];
+}
+
 #pragma mark NSSharingServicePickerDelegate methods
-
 
 - (NSArray *)sharingServicePicker:(NSSharingServicePicker *)sharingServicePicker sharingServicesForItems:(NSArray *)items mask:(NSSharingServiceMask)mask proposedSharingServices:(NSArray *)proposedServices
@@ -124 +161 @@
         return;
 
-    RetainPtr<CGImageSourceRef> source = adoptCF(CGImageSourceCreateWithData((CFDataRef)[items objectAtIndex:0], NULL));
-    RetainPtr<CGImageRef> cgImage = adoptCF(CGImageSourceCreateImageAtIndex(source.get(), 0, NULL));
-
-    if (!cgImage)
-        return;
-
-    Page* page = [_menuClient->webView() page];
-    if (!page)
-        return;
-
-    NSPasteboard *pasteboard = [NSPasteboard pasteboardWithName:serviceControlsPasteboardName];
-    [pasteboard declareTypes:@[ NSPasteboardTypeTIFF ] owner:nil];
-    [pasteboard setData:[items objectAtIndex:0] forType:NSPasteboardTypeTIFF];
-
-    Frame& frame = page->focusController().focusedOrMainFrame();
-    if (!frame.selection().isNone())
-        frame.editor().readSelectionFromPasteboard(serviceControlsPasteboardName);
-
+    id item = [items objectAtIndex:0];
+
+    if ([item isKindOfClass:[NSImage class]])
+        [self didShareImageData:[item TIFFRepresentation] confirmDataIsValidTIFFData:NO];
+    else if ([item isKindOfClass:[NSItemProvider class]]) {
+        NSItemProvider *itemProvider = (NSItemProvider *)item;
+        NSString *itemUTI = itemProvider.registeredTypeIdentifiers.firstObject;
+        
+        [itemProvider loadItemForTypeIdentifier:itemUTI options:nil completionHandler:^(id receivedData, NSError *dataError) {
+            if (!receivedData) {
+                LOG_ERROR("Did not receive data from NSItemProvider");
+                return;
+            }
+
+            if (![receivedData isKindOfClass:[NSData class]]) {
+                LOG_ERROR("Data received from NSItemProvider is not of type NSData");
+                return;
+            }
+
+            [[NSOperationQueue mainQueue] addOperationWithBlock:^{
+                [self didShareImageData:receivedData confirmDataIsValidTIFFData:YES];
+            }];
+
+        }];
+    } else
+        LOG_ERROR("sharingService:didShareItems: - Unknown item type returned");
+}
+
+- (void)sharingService:(NSSharingService *)sharingService didFailToShareItems:(NSArray *)items error:(NSError *)error
+{
     [self clear];
 }
 
-- (void)sharingService:(NSSharingService *)sharingService didFailToShareItems:(NSArray *)items error:(NSError *)error
-{
-    [self clear];
-}
-
 - (NSWindow *)sharingService:(NSSharingService *)sharingService sourceWindowForShareItems:(NSArray *)items sharingContentScope:(NSSharingContentScope *)sharingContentScope
 {

trunk/Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm

@@ -51 +51 @@
 #import <WebCore/LocalizedStrings.h>
 #import <WebCore/Page.h>
+#import <WebCore/SharedBuffer.h>
 #import <WebCore/Frame.h>
 #import <WebCore/FrameView.h>
@@ -364 +365 @@
     if (Image* image = page->contextMenuController().context().controlledImage()) {
         ASSERT(page->contextMenuController().context().hitTestResult().innerNode());
+
+        RefPtr<SharedBuffer> data = image->data();
+        ASSERT(data);
+        RetainPtr<CFDataRef> cfData = data->createCFData();
+
         bool isContentEditable = page->contextMenuController().context().hitTestResult().innerNode()->isContentEditable();
-        m_sharingServicePickerController = adoptNS([[WebSharingServicePickerController alloc] initWithImage:image->getNSImage() includeEditorServices:isContentEditable menuClient:this]);
+        m_sharingServicePickerController = adoptNS([[WebSharingServicePickerController alloc] initWithData:(NSData *)cfData.get() includeEditorServices:isContentEditable menuClient:this]);
         
         return [m_sharingServicePickerController menu];